Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version check for LegacyGeoShapeFieldMapper #38547

Merged
merged 3 commits into from
Feb 11, 2019

Conversation

nknize
Copy link
Contributor

@nknize nknize commented Feb 6, 2019

BaseGeoShapeFieldMapper version check needs to be changed from 7.0 to 6.6 to correctly use LegacyGeoShapeFieldMapper for indexes created prior to 6.6.

Version check needs to be changed from 7.0 to 6.6 to correct for backwards compatibility.
@nknize nknize added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes v7.0.0 labels Feb 6, 2019
@nknize nknize requested a review from jimczi February 6, 2019 23:08
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nknize . I think you can label it as a non-issue since it doesn't affect any released version ?

@nknize
Copy link
Contributor Author

nknize commented Feb 11, 2019

@elasticmachine run elasticsearch-ci/packaging-sample

@nknize nknize merged commit d07e61b into elastic:master Feb 11, 2019
nknize added a commit that referenced this pull request Feb 11, 2019
Change version check from 7.0 to 6.6 in BaseGeoShapeFieldMapper to correctly use LegacyGeoShapeFieldMapper for indexes created prior to 6.6.
nknize added a commit that referenced this pull request Feb 11, 2019
Change version check from 7.0 to 6.6 in BaseGeoShapeFieldMapper to correctly use LegacyGeoShapeFieldMapper for indexes created prior to 6.6.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 12, 2019
* master:
  Enable removal of retention leases (elastic#38751)
  Make the 'get templates' types deprecation message consistent. (elastic#38533)
  Copy retention leases when trim unsafe commits (elastic#37995)
  Fix the version check for LegacyGeoShapeFieldMapper (elastic#38547)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 12, 2019
* master:
  Enable removal of retention leases (elastic#38751)
  Make the 'get templates' types deprecation message consistent. (elastic#38533)
  Copy retention leases when trim unsafe commits (elastic#37995)
  Fix the version check for LegacyGeoShapeFieldMapper (elastic#38547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug >non-issue v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants