Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make credentials mandatory when launching xpack/migrate #36197

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Dec 4, 2018

Made credentials mandatory for xpack migrate tool.
Closes #29847.

The x-pack user and roles APIs aren't available unless security is enabled, so the tool should always be called with the -u and -p options specified.

Relates: #33972

Made credentials mandatory for xpack. Closes elastic#29847.
The x-pack user and roles APIs aren't available unless security is enabled, so the tool should always be called with the -u and -p options specified.
@tvernum tvernum added >enhancement v7.0.0 :Security/Security Security issues without another label v6.6.0 labels Dec 4, 2018
@tvernum tvernum requested a review from bizybot December 4, 2018 06:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Contributor

@bizybot bizybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@tvernum tvernum merged commit 3272538 into elastic:master Dec 5, 2018
@tvernum
Copy link
Contributor Author

tvernum commented Dec 5, 2018

Sorry @anuptripathi4u, I forgot that Github would lose your authorship when this was squash-merged. I'll endeavour to include you as the author when I backport this change to 6.x

@atript8
Copy link

atript8 commented Dec 6, 2018

No worries @tvernum . Thanks.

tvernum pushed a commit that referenced this pull request Dec 6, 2018
Made credentials mandatory for xpack migrate tool.
Closes #29847.

The x-pack user and roles APIs aren't available unless security is enabled, so the tool should always be called with the -u and -p options specified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants