Make credentials mandatory when launching x-pack/migrate

[atript8]

Made credentials mandatory for x-pack. Closes #29847.
The x-pack user and roles APIs aren't available unless security is enabled, so the tool should always be called with the -u and -p options specified.

[elasticmachine]

Pinging @elastic/es-security

[tvernum]

Thank @anuptripathi4u

The change looks good. We do like these sorts of fixes to have an accompanying test case.

An appropriate test would to be add something like this to ESNativeRealmMigrateToolTests:

public void testMissingPasswordParameter() throws Exception {
    ESNativeRealmMigrateTool.MigrateUserOrRoles muor = new ESNativeRealmMigrateTool.MigrateUserOrRoles();

    final OptionException ex = expectThrows(OptionException.class,
        () -> muor.getParser().parse("-u", "elastic", "-U", "http://localhost:9200"));

    assertThat(ex.getMessage(), containsString("password"));
}

Would you be able to add that?

[tvernum]

@elasticmachine test this please

[atript8]

Hi @tvernum , I stole your code but can't get the tests to work.
gradlew test -Dtests.class=org.elasticsearch.xpack.security.authc.esnative.ESNativeMigrateToolTests
test.log

Any suggestions? Do we really need hadoop setup to run the tests?

[tvernum]

@anuptripathi4u
The error isn't actually Hadoop related - that message is indicating that the hadoop tests were skipped.

The issue is that if you specify a particular test case to run, then you can only run the project that includes that test class.
The :test:framework:test task is failing because there are no tests to run, and we treat that as an error.

You probably want to run:

gradlew :x-pack:plugin:security:test -Dtests.class=org.elasticsearch.xpack.security.authc.esnative.ESNativeMigrateToolTests

[atript8]

Thanks @tvernum . Tests work. Added commit to the pull request.
I suppose I need to squash the commits into one and rebase. I am looking into it.

[atript8]

Hi @tvernum . I've squashed the commits.

[tvernum]

Hi @anuptripathi4u

Thanks.

In general we prefer that you just do regular merges, and don't squash commits, as it breaks the github review history.
We always do squashed merges, so we don't need it to be squashed ahead of time.

[tvernum]

@elasticmachine test this please.

[tvernum]

@anuptripathi4u I'm going to close this PR and open a new branch from your commit, so I can get CI working.