Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate percolate in api spec #34771

Conversation

roelandvanbatenburg
Copy link

@colings86 colings86 added the :Search Relevance/Percolator Reverse search: find queries that match a document label Oct 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@mayya-sharipova
Copy link
Contributor

@nik9000 Nik, I would like to get your advice - what is a way we want to indicate that certain endpoint/fields are deprecated in the REST API speciations? Do we want to you a new api versioning for that?

@nik9000
Copy link
Member

nik9000 commented Oct 30, 2018

I would like to get your advice - what is a way we want to indicate that certain endpoint/fields are deprecated in the REST API speciations?

I don't know! I'm asking some clients folks to see if they have any preference. I suspect we don't have a standard.

Do we want to you a new api versioning for that?

I don't think we need anything fancy for this because it is against 5.6.

@mayya-sharipova
Copy link
Contributor

Adding a "discuss" label to discuss with the team how to indicate in the REST API specifications that an API is deprecated.

@javanna
Copy link
Member

javanna commented Feb 25, 2019

@mayya-sharipova can you remind me if we discussed this? What is the plan with this PR? Thanks!

@mayya-sharipova
Copy link
Contributor

@javanna We have not yet finalized the standards for documenting deprecated REST API. I will mark #35262 for discuss in the next fixit Friday.

@romseygeek
Copy link
Contributor

The percolate endpoints are long gone from both elasticsearch and the rest api spec, so we can close this.

@romseygeek romseygeek closed this Feb 25, 2020
@roelandvanbatenburg roelandvanbatenburg deleted the feature/deprecate_percolate_in_api-spec branch February 25, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Percolator Reverse search: find queries that match a document stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants