-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define standards to deprecate in Rest Api Spec #35262
Comments
My suggestion is to add a "deprecated" : {
"version": "5.0",
"description" : "Use regular count endpoint instead."
} And depending what is deprecated (main API, or a field) put it on the corresponding level. Example - the whole API is deprecated: {
"count_percolate": {
"documentation": "https://www.elastic.co/guide/en/elasticsearch/reference/5.x/search-percolate.html",
"methods": ["GET", "POST"],
"url": {},
"body" : {},
"deprecated" : {
"version": "5.0",
"description" : "Use regular count endpoint instead."
}
} |
Pinging @elastic/es-core-infra |
Love this proposal, would love to help out getting this into the rest spec. One remaining question I have is around deprecated urls paths. In #38102 I proposed: "deprecated_paths": ["/{index}/{type}/{id}"] But perhaps the following falls more in line with your proposal @mayya-sharipova "deprecated_paths": [ { "url": "/{index}/{type}/{id}", "version": "5.0", "description": "" } ] cc @elastic/es-clients |
closing the issue, as it will be addressed by #39063 |
* fix #35262 define deprecations of API's as a whole and urls * document hot threads deprecated paths * deprecate scroll_id as part of the URL, documented only as part of the body which is a safer behaviour as well * use version numbers up to patch version * rest spec parser picks up deprecated paths as paths too
* fix #35262 define deprecations of API's as a whole and urls * document hot threads deprecated paths * deprecate scroll_id as part of the URL, documented only as part of the body which is a safer behaviour as well * use version numbers up to patch version * rest spec parser picks up deprecated paths as paths too (cherry picked from commit 7e06023)
…lastic#39063) * fix elastic#35262 define deprecations of API's as a whole and urls * document hot threads deprecated paths * deprecate scroll_id as part of the URL, documented only as part of the body which is a safer behaviour as well * use version numbers up to patch version * rest spec parser picks up deprecated paths as paths too
* Documents the new deprecations options on the rest-api-spec Relates #41439 #38613 #35262 * remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts
…41444) * Documents the new deprecations options on the rest-api-spec Relates elastic#41439 elastic#38613 elastic#35262 * remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
…41444) * Documents the new deprecations options on the rest-api-spec Relates elastic#41439 elastic#38613 elastic#35262 * remove reference to path now that elastic#41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
…43090) * Documents the new deprecations options on the rest-api-spec Relates #41439 #38613 #35262 * remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
…43089) * Documents the new deprecations options on the rest-api-spec Relates #41439 #38613 #35262 * remove reference to path now that #41452 is merged, also fixed missing a comma rendering the example json invalid * removed one more instance of path * make sure json examples are self contained and not excerpts (cherry picked from commit 4430f99)
It seems that we don't have a standard to deprecate APIs or part of APIs (fields, methods etc) in our Rest API specification files:
rest-api-spec/src/main/resources/rest-api-spec/api/*.json
In this issue we can propose possible ways to define deprecations, and come up with a single standard way.
relates to #34771
The text was updated successfully, but these errors were encountered: