Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Removing unused version.* fields #33790

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Sep 18, 2018

Backport of #33584 and #33833.

This PR removes fields that are not actually used by the Monitoring UI. This will greatly simplify the eventual migration to using Metricbeat for monitoring Elasticsearch (see elastic/beats#8260 (comment) for more context and discussion around removing these fields from ES collection).

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@ycombinator
Copy link
Contributor Author

Jenkins, test this

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - And I apologize for not having reviewed the master PR.

@ycombinator ycombinator force-pushed the x-pack/monitoring/uncollect-unused-fields/backport-6x branch from d69f115 to 4eccfce Compare September 18, 2018 09:06
This PR removes fields that are not actually used by the Monitoring UI. This will greatly simplify the eventual migration to using Metricbeat for monitoring Elasticsearch (see elastic/beats#8260 (comment) for more context and discussion around removing these fields from ES collection).
@ycombinator ycombinator force-pushed the x-pack/monitoring/uncollect-unused-fields/backport-6x branch from 4eccfce to 5c4b716 Compare September 18, 2018 14:57
@ycombinator ycombinator merged commit 078959c into elastic:6.x Sep 18, 2018
@ycombinator ycombinator deleted the x-pack/monitoring/uncollect-unused-fields/backport-6x branch September 18, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants