Cherry-pick #8260 to 6.x: Adding x-pack code for elasticsearch/index metricset
#8337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating test fixture * Extract indicesStruct for reuse within package * Only request specific stats * Add X-Pack switch * Adding explanatory comment * Fleshing it out some more * Remove empty TODO * Adding reference comment for fields + refactoring into helper funcs * Re-formatting * Extract stats API metrics into own const * Using errors.Wrap * Adding logger to elasticsearch metricset * Log errors * Sharing the type not the variable 🤦 (cherry picked from commit cfee760)
houndci-bot
reviewed
Sep 18, 2018
| @@ -29,6 +29,10 @@ import ( | |||
| "github.com/elastic/beats/metricbeat/module/elasticsearch" | |||
| ) | |||
|
|
|||
| type IndicesStruct struct { | |||
There was a problem hiding this comment.
exported type IndicesStruct should have comment or be unexported
|
Depends on elastic/elasticsearch#33790 to be merged first. |
jsoriano
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8260 to 6.x branch. Original message:
This PR teaches metricbeat to index
index_statsdocuments into.monitoring-es-6-mb-*indices.