Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Return correct catalog separator in JDBC #33670

Merged
merged 1 commit into from
Sep 13, 2018
Merged

SQL: Return correct catalog separator in JDBC #33670

merged 1 commit into from
Sep 13, 2018

Conversation

costin
Copy link
Member

@costin costin commented Sep 13, 2018

Return : instead of . (which leads to syntax errors).

Fix #33654

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

astefan
astefan approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matriv
matriv approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit 60ab4f9 into elastic:master Sep 13, 2018
@costin costin deleted the fix-33654 branch September 13, 2018 18:55
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 13, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into global-checkpoint-…
426b359 
…polling

* elastic/master:
  SQL: Return correct catalog separator in JDBC (elastic#33670)
  [CCR] Add validation for max_retry_delay (elastic#33648)
  [CCR] Add monitoring mapping verification test (elastic#33662)
  CORE: Disable Setting Type Validation (elastic#33660) (elastic#33669)
  Revert "Use serializable exception in GCP listeners (elastic#33657)"
  Adding index refresh (elastic#33647)
  [DOCS] Moves securing-communications to docs (elastic#33640)
  [HLRC][ML] Add ML delete datafeed API to HLRC (elastic#33667)
  Mute testRecoveryWithConcurrentIndexing
  TEST: decrease logging level in the flush test
  DOC: Add SQL section on client applications
  Fix race in global checkpoint listeners test
  Use serializable exception in GCP listeners (elastic#33657)
costin added a commit that referenced this pull request Sep 13, 2018
@costin
SQL: Return correct catalog separator in JDBC (#33670)
c922f72 
JDBC DatabaseMetadata returns correct separator (:) for catalog/cluster names.

Fix #33654 

(cherry picked from commit 60ab4f9)
costin added a commit that referenced this pull request Sep 13, 2018
@costin
SQL: Return correct catalog separator in JDBC (#33670)
e36acdb 
JDBC DatabaseMetadata returns correct separator (:) for catalog/cluster names.

Fix #33654

(cherry picked from commit c922f72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matriv matriv matriv approved these changes

@astefan astefan astefan approved these changes

@bpintea bpintea Awaiting requested review from bpintea

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug v6.4.1 v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@costin @elasticmachine @astefan @matriv @colings86