Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLRC][ML] Add ML delete datafeed API to HLRC #33667

Conversation

dimitris-athanasiou
Copy link
Contributor

Relates #29827

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@dimitris-athanasiou dimitris-athanasiou force-pushed the add-ml-delete-datafeed-to-hlrc branch from 5d0516c to 69fa30d Compare September 13, 2018 11:53
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one tiny typo in a Javadoc comment

}

/**
* Used to forcefully delete an started datafeed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "an started" -> "a started"

@dimitris-athanasiou
Copy link
Contributor Author

Fixed the typo. As it was just a typo I'll merge without waiting for CI.

@dimitris-athanasiou dimitris-athanasiou merged commit 9600819 into elastic:master Sep 13, 2018
@dimitris-athanasiou dimitris-athanasiou deleted the add-ml-delete-datafeed-to-hlrc branch September 13, 2018 16:13
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 13, 2018
…polling

* elastic/master:
  SQL: Return correct catalog separator in JDBC (elastic#33670)
  [CCR] Add validation for max_retry_delay (elastic#33648)
  [CCR] Add monitoring mapping verification test (elastic#33662)
  CORE: Disable Setting Type Validation (elastic#33660) (elastic#33669)
  Revert "Use serializable exception in GCP listeners (elastic#33657)"
  Adding index refresh (elastic#33647)
  [DOCS] Moves securing-communications to docs (elastic#33640)
  [HLRC][ML] Add ML delete datafeed API to HLRC (elastic#33667)
  Mute testRecoveryWithConcurrentIndexing
  TEST: decrease logging level in the flush test
  DOC: Add SQL section on client applications
  Fix race in global checkpoint listeners test
  Use serializable exception in GCP listeners (elastic#33657)
@benwtrent benwtrent removed the :ml Machine learning label Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants