-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling testing against an external cluster #30885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today when executing REST tests we take full responsibility for cluster configuration. Yet, there are use cases for brining your own cluster to the REST tests. This commit is a small first step towards that effort by skipping creating the cluster if the tests.rest.cluster and test.cluster system properties are set. In this case, the user takes full responsibility for configuring the cluster as expected by the REST tests. This step is by no means meant to be perfect or complete, only a baby step.
jasontedor
added
review
:Delivery/Build
Build or test infrastructure
v7.0.0
v6.3.0
v6.4.0
labels
May 25, 2018
Pinging @elastic/es-core-infra |
retest this please |
…ster * elastic/master: Do not serialize basic license exp in x-pack info (elastic#30848) Change BWC version for VerifyRepositoryResponse (elastic#30796) [DOCS] Document index name limitations (elastic#30826) Harmonize include_defaults tests (elastic#30700) [TEST] Mute {p0=snapshot.get_repository/10_basic/Verify created repository} YAML test
retest this please |
rjernst
approved these changes
May 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
retest this please |
run sample packaging tests |
jasontedor
added a commit
that referenced
this pull request
May 26, 2018
Today when executing REST tests we take full responsibility for cluster configuration. Yet, there are use cases for brining your own cluster to the REST tests. This commit is a small first step towards that effort by skipping creating the cluster if the tests.rest.cluster and test.cluster system properties are set. In this case, the user takes full responsibility for configuring the cluster as expected by the REST tests. This step is by no means meant to be perfect or complete, only a baby step.
jasontedor
added a commit
that referenced
this pull request
May 26, 2018
Today when executing REST tests we take full responsibility for cluster configuration. Yet, there are use cases for brining your own cluster to the REST tests. This commit is a small first step towards that effort by skipping creating the cluster if the tests.rest.cluster and test.cluster system properties are set. In this case, the user takes full responsibility for configuring the cluster as expected by the REST tests. This step is by no means meant to be perfect or complete, only a baby step.
dnhatn
added a commit
that referenced
this pull request
May 28, 2018
* master: silence InstallPluginCommandTests, see #30900 Remove left-over comment Fix double semicolon in import statement [TEST] Fix minor random bug from #30794 Include size of snapshot in snapshot metadata #18543, bwc clean up (#30890) Enabling testing against an external cluster (#30885) Add public key header/footer (#30877) SQL: Remove the last remaining server dependencies from jdbc (#30771) Include size of snapshot in snapshot metadata (#29602) Do not serialize basic license exp in x-pack info (#30848) Change BWC version for VerifyRepositoryResponse (#30796) [DOCS] Document index name limitations (#30826) Harmonize include_defaults tests (#30700)
dnhatn
added a commit
that referenced
this pull request
May 28, 2018
* 6.x: Fix double semicolon in import statement [TEST] Fix minor random bug from #30794 Enabling testing against an external cluster (#30885) SQL: Remove the last remaining server dependencies from jdbc (#30771) Add public key header/footer (#30877) Include size of snapshot in snapshot metadata (#29602) QA: Test template creation during rolling restart (#30850) REST high-level client: add put ingest pipeline API (#30793) Do not serialize basic license exp in x-pack info (#30848) [docs] explainer for java packaging tests (#30825) Verify signatures on official plugins (#30800) [DOCS] Document index name limitations (#30826) [Docs] Add reindex.remote.whitelist example (#30828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Build
Build or test infrastructure
Team:Delivery
Meta label for Delivery team
v6.3.0
v6.4.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when executing REST tests we take full responsibility for cluster configuration. Yet, there are use cases for brining your own cluster to the REST tests. This commit is a small first step towards that effort by skipping creating the cluster if the tests.rest.cluster and test.cluster system properties are set. In this case, the user takes full responsibility for configuring the cluster as expected by the REST tests. This step is by no means meant to be perfect or complete, only a baby step.