-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize include_defaults tests #30700
Merged
tomcallahan
merged 2 commits into
elastic:master
from
tomcallahan:harmonize-includedefaults-tests
May 25, 2018
Merged
Harmonize include_defaults tests #30700
tomcallahan
merged 2 commits into
elastic:master
from
tomcallahan:harmonize-includedefaults-tests
May 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR breaks the include_defaults functionality of the get settings API into its own test, which is skipped for mixed-mode clusters containing pre-6.4 nodes.
javanna
approved these changes
May 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @tomcallahan
colings86
added
>enhancement
:Core/Infra/Settings
Settings infrastructure and APIs
labels
May 18, 2018
Pinging @elastic/es-core-infra |
@elasticmachine test this please |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 25, 2018
* elastic/master: Do not serialize basic license exp in x-pack info (elastic#30848) Change BWC version for VerifyRepositoryResponse (elastic#30796) [DOCS] Document index name limitations (elastic#30826) Harmonize include_defaults tests (elastic#30700) [TEST] Mute {p0=snapshot.get_repository/10_basic/Verify created repository} YAML test
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 25, 2018
…ster * elastic/master: Do not serialize basic license exp in x-pack info (elastic#30848) Change BWC version for VerifyRepositoryResponse (elastic#30796) [DOCS] Document index name limitations (elastic#30826) Harmonize include_defaults tests (elastic#30700) [TEST] Mute {p0=snapshot.get_repository/10_basic/Verify created repository} YAML test
dnhatn
added a commit
that referenced
this pull request
May 28, 2018
* master: silence InstallPluginCommandTests, see #30900 Remove left-over comment Fix double semicolon in import statement [TEST] Fix minor random bug from #30794 Include size of snapshot in snapshot metadata #18543, bwc clean up (#30890) Enabling testing against an external cluster (#30885) Add public key header/footer (#30877) SQL: Remove the last remaining server dependencies from jdbc (#30771) Include size of snapshot in snapshot metadata (#29602) Do not serialize basic license exp in x-pack info (#30848) Change BWC version for VerifyRepositoryResponse (#30796) [DOCS] Document index name limitations (#30826) Harmonize include_defaults tests (#30700)
tomcallahan
added a commit
that referenced
this pull request
May 31, 2018
This PR breaks the include_defaults functionality of the get settings API into its own test, which is skipped for mixed-mode clusters containing pre-6.4 nodes.
dnhatn
added a commit
that referenced
this pull request
May 31, 2018
* 6.x: HLRest: Allow caller to set per request options (#30490) Limit the scope of BouncyCastle dependency (#30959) Deprecates indexing and querying a context completion field without context (#31006) [DOCS] Clarify not all PKCS12 usable as truststores (#30750) Harmonize include_defaults tests (#30700) [DOCS] Update readme for testing x-pack code snippets (#30696) [Docs] Fix typo in Min Aggregation reference (#30899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the include_defaults functionality of the get settings API into its own
test, which is skipped for mixed-mode clusters containing pre-6.4 nodes.