Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize include_defaults tests #30700

Merged

Conversation

tomcallahan
Copy link
Contributor

This PR breaks the include_defaults functionality of the get settings API into its own
test, which is skipped for mixed-mode clusters containing pre-6.4 nodes.

This PR breaks the include_defaults functionality of the get settings API into its own
test, which is skipped for mixed-mode clusters containing pre-6.4 nodes.
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @tomcallahan

@colings86 colings86 added >enhancement :Core/Infra/Settings Settings infrastructure and APIs labels May 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@tomcallahan
Copy link
Contributor Author

@elasticmachine test this please

@tomcallahan tomcallahan merged commit 36fbb4c into elastic:master May 25, 2018
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 25, 2018
* elastic/master:
  Do not serialize basic license exp in x-pack info (elastic#30848)
  Change BWC version for VerifyRepositoryResponse (elastic#30796)
  [DOCS] Document index name limitations (elastic#30826)
  Harmonize include_defaults tests (elastic#30700)
  [TEST] Mute {p0=snapshot.get_repository/10_basic/Verify created repository} YAML test
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 25, 2018
…ster

* elastic/master:
  Do not serialize basic license exp in x-pack info (elastic#30848)
  Change BWC version for VerifyRepositoryResponse (elastic#30796)
  [DOCS] Document index name limitations (elastic#30826)
  Harmonize include_defaults tests (elastic#30700)
  [TEST] Mute {p0=snapshot.get_repository/10_basic/Verify created repository} YAML test
dnhatn added a commit that referenced this pull request May 28, 2018
* master:
  silence InstallPluginCommandTests, see #30900
  Remove left-over comment
  Fix double semicolon in import statement
  [TEST] Fix minor random bug from #30794
  Include size of snapshot in snapshot metadata #18543, bwc clean up (#30890)
  Enabling testing against an external cluster (#30885)
  Add public key header/footer (#30877)
  SQL: Remove the last remaining server dependencies from jdbc (#30771)
  Include size of snapshot in snapshot metadata (#29602)
  Do not serialize basic license exp in x-pack info (#30848)
  Change BWC version for VerifyRepositoryResponse (#30796)
  [DOCS] Document index name limitations (#30826)
  Harmonize include_defaults tests (#30700)
tomcallahan added a commit that referenced this pull request May 31, 2018
This PR breaks the include_defaults functionality of the get settings API into its own
test, which is skipped for mixed-mode clusters containing pre-6.4 nodes.
dnhatn added a commit that referenced this pull request May 31, 2018
* 6.x:
  HLRest: Allow caller to set per request options (#30490)
  Limit the scope of BouncyCastle dependency (#30959)
  Deprecates indexing and querying a context completion field without context (#31006)
  [DOCS] Clarify not all PKCS12 usable as truststores (#30750)
  Harmonize include_defaults tests (#30700)
  [DOCS] Update readme for testing x-pack code snippets (#30696)
  [Docs] Fix typo in Min Aggregation reference (#30899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants