Deprecate setting index.optimize_auto_generated_id in 6.x #28862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
javanna
changed the title
|
test this please |
|
@jasontedor the build succeeded when you ran it a (long) while ago, would you mind picking this one up? |
jasontedor
requested changes
May 25, 2018
| @@ -109,6 +114,7 @@ | |||
| * this setting won't be reflected re-enabled optimization until the engine is restarted or the index is closed and reopened. | |||
| * The default is <code>true</code> | |||
| */ | |||
| @Deprecated | |||
| public static final Setting<Boolean> INDEX_OPTIMIZE_AUTO_GENERATED_IDS = Setting.boolSetting("index.optimize_auto_generated_id", true, | |||
| Property.IndexScope, Property.Dynamic); | |||
There was a problem hiding this comment.
We don't need to deprecate this in Java, but we should deprecate this with Property.Deprecated. Can you add that?
There was a problem hiding this comment.
Thanks @jasontedor , please review again.
liketic
force-pushed
the
deprecate-optimize_auto_generated_id
branch
from
9972cbc to
d155b59
Compare
|
@elasticmachine test this please |
* 6.x: (10708 commits) Add docs on replicating APM Server or Beats indices (elastic#36333) [DOCS] document that ILM and CCR do not work together (elastic#36082) [ILM] [DOCS] add general info about steps (elastic#36081) [DOCS] Add missing anchors (elastic#36288) Revert "Fix line length offenders in the o.e.search package. (elastic#36223)" Remove license state listeners on closables (elastic#36308) Adding additional tests for agg parsing in datafeedconfig (elastic#36261) Fix line length offenders in the o.e.search package. (elastic#36223) [Tests] Fix third party tests with Gradle 5.0 (elastic#36302) Docs: Add password keystore setting for email account passwords (elastic#33409) SNAPSHOT: Increase Timeout to Stabilize Test (elastic#36294) Fix get certificates HLRC API (elastic#36198) Fix typo in comment Make credentials mandatory when launching xpack/migrate (elastic#36197) [Docs] Add Profile API limitations (elastic#36252) Make sure test don't use Math.random for reproducability (elastic#36241) Add version 6.5.3 to 6.x branch (elastic#36267) [DOCS] Fixes broken link in execute watch Core: Deguice RepositoriesService (elastic#36016) (elastic#36270) Correct doc reference tag (elastic#36262) ...
|
@elasticmachine test this please |
|
@liketic Would you update EngineConfigTests so that it compiles? |
…etic/elasticsearch into deprecate-optimize_auto_generated_id
|
@elasticmachine test this please |
jasontedor
approved these changes
Dec 9, 2018
* elastic/6.x: (37 commits) [HLRC] Added support for Follow Stats API (elastic#36253) Exposed engine must have all ops below gcp during rollback (elastic#36159) TEST: Always enable soft-deletes in ShardChangesTests Use delCount of SegmentInfos to calculate numDocs (elastic#36323) Add soft-deletes upgrade tests (elastic#36286) Remove LocalCheckpointTracker#resetCheckpoint (elastic#34667) Option to use endpoints starting with _security (elastic#36379) [CCR] Restructured QA modules (elastic#36404) RestClient: on retry timeout add root exception (elastic#25576) [HLRC] Add support for put privileges API (elastic#35679) HLRC: Add rollup search (elastic#36334) Explicitly recommend to forceMerge before freezing (elastic#36376) Rename internal repository actions to be internal (elastic#36377) Core: Remove parseDefaulting from DateFormatter (elastic#36386) [ML] Prevent stack overflow while copying ML jobs and datafeeds (elastic#36370) Docs: Fix Jackson reference (elastic#36366) [ILM] Fix issue where index may not yet be in 'hot' phase (elastic#35716) Undeprecate /_watcher endpoints (elastic#36269) Docs: Fix typo in bool query (elastic#36350) HLRC: Add delete template API (elastic#36320) ...
|
@elasticmachine test this please |
|
Should this PR have a version label? |
|
I added v6.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate setting
index.optimize_auto_generated_idin 6.x.Relates to #27600