Relax remote check for bwc project checkouts #28666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remote check previously validated both the remote name and the repository as well, meaning that if someone passed in a repository that was not a github URL, it would fail. This meant that it was not possible to fully test bwc out with multiple branches without first pushing to a remote. Removing the full check allows a user to pass in the origin remote as its remote, which is already added as a file based remote to each bwc snapshot build. This will allow changes to be made locally across all bwc branches, tested, and then pushed simultaneously.
hub-cap
added a commit
to hub-cap/elasticsearch
that referenced
this pull request
Feb 13, 2018
The remote check previously validated both the remote name and the repository as well, meaning that if someone passed in a repository that was not a github URL, it would fail. This meant that it was not possible to fully test bwc out with multiple branches without first pushing to a remote. Removing the full check allows a user to pass in the origin remote as its remote, which is already added as a file based remote to each bwc snapshot build. This will allow changes to be made locally across all bwc branches, tested, and then pushed simultaneously.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 15, 2018
* master: Backported synced-flush PR to v5.6.8 and v6.2.2 Move more XContent.createParser calls to non-deprecated version (elastic#28672) Move more XContent.createParser calls to non-deprecated version (elastic#28670) Build: Group archive and package distribution projects (elastic#28673) [DOCS] Add supported token filters [TEST] bump timeout in testFetchShardsSkipUnavailable to 5s Relax remote check for bwc project checkouts (elastic#28666) [TEST] Synchronize searcher list in IndexShardTests [TEST] packaging: function to collect debug info (elastic#28608) Compute declared versions in a static block Docs: Remove references to elasticsearch directory in plugins (elastic#28647) Remove snapshot conditional for bwc snapshots (elastic#28657) Removed redundant JSON object from Put Mapping docs (elastic#28514) Update threadpool.asciidoc target_response_time (elastic#28655)
hub-cap
added a commit
that referenced
this pull request
Mar 20, 2018
The remote check previously validated both the remote name and the repository as well, meaning that if someone passed in a repository that was not a github URL, it would fail. This meant that it was not possible to fully test bwc out with multiple branches without first pushing to a remote. Removing the full check allows a user to pass in the origin remote as its remote, which is already added as a file based remote to each bwc snapshot build. This will allow changes to be made locally across all bwc branches, tested, and then pushed simultaneously.
hub-cap
added a commit
that referenced
this pull request
Mar 20, 2018
The remote check previously validated both the remote name and the repository as well, meaning that if someone passed in a repository that was not a github URL, it would fail. This meant that it was not possible to fully test bwc out with multiple branches without first pushing to a remote. Removing the full check allows a user to pass in the origin remote as its remote, which is already added as a file based remote to each bwc snapshot build. This will allow changes to be made locally across all bwc branches, tested, and then pushed simultaneously.
martijnvg
added a commit
that referenced
this pull request
Mar 21, 2018
* es/6.x: (46 commits) Docs: Add note about missing mapping for doc values field (#29036) [DOCS] Removed 6.1.4, 6.2.2, and 6.2.3 coming tags Remove BytesArray and BytesReference usage from XContentFactory (#29151) Fix BWC issue for PreSyncedFlushResponse Add pluggable XContentBuilder writers and human readable writers (#29120) Add unreleased version 6.2.4 (#29171) Add unreleased version 6.1.5 (#29168) Add a note about using the `retry_failed` flag before accepting data loss (#29160) Fix typo in percolate-query.asciidoc (#29155) Add release notes for 6.1.4 and 6.2.3 Require HTTP::Tiny 0.070 for release notes script REST high-level client: add clear cache API (#28866) Relax remote check for bwc project checkouts (#28666) Set Java 9 checkstyle to depend on checkstyle conf (#28383) Docs: Add example of resetting index setting (#29048) Plugins: Fix module name conflict check for meta plugins (#29146) Build: Fix meta plugin bundled plugin names (#29147) Build: Simplify rest spec hack configuration (#29149) CLI: Close subcommands in MultiCommand (#28954) Build: Fix meta modules to not install as plugin in tests (#29150) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote check previously validated both the remote name and the
repository as well, meaning that if someone passed in a repository that
was not a github URL, it would fail. This meant that it was not possible
to fully test bwc out with multiple branches without first pushing to a
remote. Removing the full check allows a user to pass in the origin
remote as its remote, which is already added as a file based remote to
each bwc snapshot build. This will allow changes to be made locally
across all bwc branches, tested, and then pushed simultaneously.