Skip to content

Commit

Permalink
Relax remote check for bwc project checkouts (#28666)
Browse files Browse the repository at this point in the history
The remote check previously validated both the remote name and the
repository as well, meaning that if someone passed in a repository that
was not a github URL, it would fail. This meant that it was not possible
to fully test bwc out with multiple branches without first pushing to a
remote. Removing the full check allows a user to pass in the origin
remote as its remote, which is already added as a file based remote to
each bwc snapshot build. This will allow changes to be made locally
across all bwc branches, tested, and then pushed simultaneously.
  • Loading branch information
hub-cap committed Mar 20, 2018
1 parent d8654c3 commit 9a463fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion distribution/bwc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ subprojects {
doLast {
project.ext.remoteExists = false
output.toString('UTF-8').eachLine {
if (it.contains("${remote}\thttps://github.com/${remote}/elasticsearch.git")) {
if (it.contains("${remote}\t")) {
project.ext.remoteExists = true
}
}
Expand Down

0 comments on commit 9a463fd

Please sign in to comment.