Create new handlers for every new request in GoogleCloudStorageService #27339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the DefaultHttpRequestInitializer in order to make it create new HttpIOExceptionHandler and HttpUnsuccessfulResponseHandler for every new HTTP request instead of reusing the same two handlers for all requests. Closes elastic#27092
|
I have no dev environment to test me, but the code lgtm. Thank you. |
rjernst
reviewed
Nov 10, 2017
| @@ -47,13 +65,56 @@ GoogleCredential getDefaultCredential() throws IOException { | |||
| } | |||
| }; | |||
| assertSame(cred, service.getCredential("default")); | |||
|
|
|||
| service.new DefaultHttpRequestInitializer(cred, null, null); | |||
There was a problem hiding this comment.
Is this a typo? Not sure how this compiles...
There was a problem hiding this comment.
It's a non-static inner class, that's the syntax for constructing an instance of an inner class that is tied to an instance of the outer class.
There was a problem hiding this comment.
Ahhh, it's been a long time since I have seen this syntax...
rjernst
approved these changes
Nov 10, 2017
|
Thanks @thkoch2001 and @rjernst |
|
@tlrx : Will this be available in ES 6.0.1? |
|
@msahnawaz Yes, that's what the tag |
martijnvg
added a commit
that referenced
this pull request
Nov 15, 2017
* es/master: Logging: Unify log rotation for index/search slow log (#27298) wildcard query on _index (#27334) REST spec: Validate that api name matches file name that contains it (#27366) Revert "Reduce synchronization on field data cache" Create new handlers for every new request in GoogleCloudStorageService (#27339) Rest test fixes (#27354)
martijnvg
added a commit
that referenced
this pull request
Nov 15, 2017
* es/6.x: Updated 6.0.0 release notes to include all changes from alpha, beta, RC wildcard query on _index (#27334) REST spec: Validate that api name matches file name that contains it (#27366) Revert "Reduce synchronization on field data cache" Create new handlers for every new request in GoogleCloudStorageService (#27339) Rest test fixes (#27354)
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the
DefaultHttpRequestInitializerin order to makeit create new
HttpIOExceptionHandlerandHttpUnsuccessfulResponseHandlerfor every new HTTP request instead of reusing the same two handlers for
all requests.
It also add a test for this and removes some unused attributes.
Closes #27092