Logging: Unify log rotation for index/search slow log #27298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing log rotation configuration allowed the index and search slow log to grow unbounded. This commit removes the date based rotation and adds the same size based rotation, that the depreciation log already has.
spinscale
added
:Core/Infra/Logging
ywelsch
suggested changes
Nov 13, 2017
There was a problem hiding this comment.
The slowlog.asciidoc documentation needs to be updated, as it still refers to the old time-based policy.
I think @jasontedor should give this a look as well.
jasontedor
requested changes
Nov 13, 2017
There was a problem hiding this comment.
The change itself LGTM, but I agree with @ywelsch that the docs need to updated too.
|
good call. synced docs with the configuration file and saw that a few more lines needed fixing |
martijnvg
added a commit
that referenced
this pull request
Nov 15, 2017
* es/master: Logging: Unify log rotation for index/search slow log (#27298) wildcard query on _index (#27334) REST spec: Validate that api name matches file name that contains it (#27366) Revert "Reduce synchronization on field data cache" Create new handlers for every new request in GoogleCloudStorageService (#27339) Rest test fixes (#27354)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing log rotation configuration allowed the index
and search slow log to grow unbounded. This commit removes the
date based rotation and adds the same size based rotation, that
the depreciation log already has.
Tested this locally with logstash using the generator and the elasticsearch inputs and worked fine.