Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Build] Cache spotless p2 dependencies when baking ci image (#118523) #118593

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

breskeby
Copy link
Contributor

Backports the following commits to 8.x:

…#118523)

The eclipse formatter used by spotless is resolved at runtime and not declared as
gradle dependency. Therefore we need to run the spotless task to ensure we have
the dependencies resolved as part of our ci image baking.

This should avoid issues with connecting to p2 repos we have experienced lately
in our ci environment

* Revert "[Build] Declare mirror for eclipse p2 repository (elastic#117732)"

This reverts commit c35777a.
@breskeby breskeby added :Delivery/Build Build or test infrastructure >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Delivery Meta label for Delivery team labels Dec 12, 2024
@breskeby breskeby merged commit ef03097 into elastic:8.x Dec 12, 2024
13 of 16 checks passed
@breskeby breskeby deleted the backport/8.x/pr-118523 branch December 12, 2024 21:15
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
…#118523) (elastic#118593)

The eclipse formatter used by spotless is resolved at runtime and not declared as
gradle dependency. Therefore we need to run the spotless task to ensure we have
the dependencies resolved as part of our ci image baking.

This should avoid issues with connecting to p2 repos we have experienced lately
in our ci environment

* Revert "[Build] Declare mirror for eclipse p2 repository (elastic#117732)"

This reverts commit c35777a.
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
…#118523) (elastic#118593)

The eclipse formatter used by spotless is resolved at runtime and not declared as
gradle dependency. Therefore we need to run the spotless task to ensure we have
the dependencies resolved as part of our ci image baking.

This should avoid issues with connecting to p2 repos we have experienced lately
in our ci environment

* Revert "[Build] Declare mirror for eclipse p2 repository (elastic#117732)"

This reverts commit c35777a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants