[Build] Declare mirror for eclipse p2 repository #117732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository`
breskeby
added
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Some relevant info on |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Nov 29, 2024
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository`
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Nov 29, 2024
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository`
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Nov 29, 2024
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository`
💔 Backport failed
You can use sqren/backport to manually backport by running |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Nov 29, 2024
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository` (cherry picked from commit c35777a) # Conflicts: # build-conventions/src/main/java/org/elasticsearch/gradle/internal/conventions/precommit/FormattingPrecommitPlugin.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 29, 2024
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository`
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 29, 2024
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository`
pugnascotia
reviewed
Nov 29, 2024
| @@ -17,6 +17,8 @@ | |||
| import org.gradle.api.Project; | |||
|
|
|||
| import java.io.File; | |||
| import java.util.Arrays; | |||
| import java.util.Map; | |||
|
|
|||
| /** | |||
| * This plugin configures formatting for Java source using Spotless | |||
There was a problem hiding this comment.
@breskeby FYI this comment block is out-of-date - we're formatting everything now.
breskeby
added a commit
that referenced
this pull request
Dec 6, 2024
The spotlight plugin directly resolves dependencies from p2 which causes `java.io.IOException: Failed to load eclipse jdt formatter` issues if that repo is not accessible. This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail. The artifacts in question we wanna cache live in `~/.m2/repository`
breskeby
pushed a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 12, 2024
)" This reverts commit c35777a.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 12, 2024
)" This reverts commit c35777a.
breskeby
added a commit
that referenced
this pull request
Dec 12, 2024
The eclipse formatter used by spotless is resolved at runtime and not declared as gradle dependency. Therefore we need to run the spotless task to ensure we have the dependencies resolved as part of our ci image baking. This should avoid issues with connecting to p2 repos we have experienced lately in our ci environment * Revert "[Build] Declare mirror for eclipse p2 repository (#117732)" This reverts commit c35777a.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 12, 2024
…#118523) The eclipse formatter used by spotless is resolved at runtime and not declared as gradle dependency. Therefore we need to run the spotless task to ensure we have the dependencies resolved as part of our ci image baking. This should avoid issues with connecting to p2 repos we have experienced lately in our ci environment * Revert "[Build] Declare mirror for eclipse p2 repository (elastic#117732)" This reverts commit c35777a.
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 12, 2024
…#118523) The eclipse formatter used by spotless is resolved at runtime and not declared as gradle dependency. Therefore we need to run the spotless task to ensure we have the dependencies resolved as part of our ci image baking. This should avoid issues with connecting to p2 repos we have experienced lately in our ci environment * Revert "[Build] Declare mirror for eclipse p2 repository (elastic#117732)" This reverts commit c35777a.
breskeby
added a commit
that referenced
this pull request
Dec 12, 2024
#118591) The eclipse formatter used by spotless is resolved at runtime and not declared as gradle dependency. Therefore we need to run the spotless task to ensure we have the dependencies resolved as part of our ci image baking. This should avoid issues with connecting to p2 repos we have experienced lately in our ci environment * Revert "[Build] Declare mirror for eclipse p2 repository (#117732)" This reverts commit c35777a.
breskeby
added a commit
that referenced
this pull request
Dec 12, 2024
#118593) The eclipse formatter used by spotless is resolved at runtime and not declared as gradle dependency. Therefore we need to run the spotless task to ensure we have the dependencies resolved as part of our ci image baking. This should avoid issues with connecting to p2 repos we have experienced lately in our ci environment * Revert "[Build] Declare mirror for eclipse p2 repository (#117732)" This reverts commit c35777a.
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…#118523) (elastic#118593) The eclipse formatter used by spotless is resolved at runtime and not declared as gradle dependency. Therefore we need to run the spotless task to ensure we have the dependencies resolved as part of our ci image baking. This should avoid issues with connecting to p2 repos we have experienced lately in our ci environment * Revert "[Build] Declare mirror for eclipse p2 repository (elastic#117732)" This reverts commit c35777a.
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…#118523) (elastic#118593) The eclipse formatter used by spotless is resolved at runtime and not declared as gradle dependency. Therefore we need to run the spotless task to ensure we have the dependencies resolved as part of our ci image baking. This should avoid issues with connecting to p2 repos we have experienced lately in our ci environment * Revert "[Build] Declare mirror for eclipse p2 repository (elastic#117732)" This reverts commit c35777a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spotlight plugin directly resolves dependencies from p2 which causes
java.io.IOException: Failed to load eclipse jdt formatterissues if that repo is not accessible.This is a workaround for the eclipse p2 default repository being down resulting in all our ci jobs to fail.
The artifacts in question we wanna cache live in
~/.m2/repository.This seems related to #100753