[Test] Ensure latest cluster info is used in tests #116908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DesiredBalanceMetrics#updateMetrics is called on reroute which is frequent but not guaranteed. It can also takes some time to complete. This PR adds an explicit reroute to ensure the latest cluster info is picked up. Resolves: elastic#116870
ywangd
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
commented
Nov 18, 2024
| @@ -68,6 +69,7 @@ public void testDesiredBalanceMetrics() { | |||
| final var infoService = (InternalClusterInfoService) internalCluster().getCurrentMasterNodeInstance(ClusterInfoService.class); | |||
| ClusterInfoServiceUtils.setUpdateFrequency(infoService, TimeValue.timeValueMillis(200)); | |||
| assertNotNull("info should not be null", ClusterInfoServiceUtils.refresh(infoService)); | |||
There was a problem hiding this comment.
It seems to me that the asyncRefresh for clusterInfo can also pause which makes the refresh call here to get back a stale result since the newRefresh is short-circuited if there is already one running. If that does happen, it might also lead to test failure. But in practice, I was not able to make it happen, probably due to the short update interval of 200ms. So I am leaving it as is.
idegtiarenko
approved these changes
Nov 18, 2024
pxsalehi
approved these changes
Nov 18, 2024
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Nov 18, 2024
DesiredBalanceMetrics#updateMetrics is called on reroute which is frequent but not guaranteed. It can also take some time to complete. This PR adds an explicit reroute to ensure the latest cluster info is picked up. Resolves: elastic#116870
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
DesiredBalanceMetrics#updateMetrics is called on reroute which is frequent but not guaranteed. It can also take some time to complete. This PR adds an explicit reroute to ensure the latest cluster info is picked up. Resolves: elastic#116870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DesiredBalanceMetrics#updateMetrics is called on reroute which is frequent but not guaranteed. It can also takes some time to complete. This PR adds an explicit reroute to ensure the latest cluster info is picked up.
Resolves: #116870