Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] DesiredBalanceReconcilerMetricsIT testDesiredBalanceMetrics failing #116870

Closed
elasticsearchmachine opened this issue Nov 15, 2024 · 2 comments · Fixed by #116908
Closed

[CI] DesiredBalanceReconcilerMetricsIT testDesiredBalanceMetrics failing #116870

elasticsearchmachine opened this issue Nov 15, 2024 · 2 comments · Fixed by #116908
Assignees
@ywangd
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Coordination Meta label for Distributed Coordination team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

./gradlew ":server:internalClusterTest" --tests "org.elasticsearch.cluster.routing.allocation.allocator.DesiredBalanceReconcilerMetricsIT.testDesiredBalanceMetrics" -Dtests.seed=B58F2379C103AA4 -Dtests.locale=ks-Arab-IN -Dtests.timezone=Etc/GMT+7 -Druntime.java=23

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: null

Issue Reasons:

  • [main] 3 failures in test testDesiredBalanceMetrics (1.0% fail rate in 294 executions)
  • [main] 2 failures in step part-1 (2.0% fail rate in 98 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (2.0% fail rate in 98 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >test-failure Triaged test failures from CI labels Nov 15, 2024
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 3 failures in test testDesiredBalanceMetrics (1.0% fail rate in 294 executions)
  • [main] 2 failures in step part-1 (2.0% fail rate in 98 executions)
  • [main] 2 failures in pipeline elasticsearch-pull-request (2.0% fail rate in 98 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Nov 15, 2024
@elasticsearchmachine
Mute org.elasticsearch.cluster.routing.allocation.allocator.DesiredBa…
56368e6 
…lanceReconcilerMetricsIT testDesiredBalanceMetrics #116870
@elasticsearchmachine elasticsearchmachine added needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Distributed Coordination Meta label for Distributed Coordination team labels Nov 15, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@ywangd ywangd self-assigned this Nov 18, 2024
@ywangd ywangd added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Nov 18, 2024
ywangd added a commit to ywangd/elasticsearch that referenced this issue Nov 18, 2024
@ywangd
[Test] Ensure latest cluster info is used in tests
60c865a 
DesiredBalanceMetrics#updateMetrics is called on reroute which is
frequent but not guaranteed. It can also takes some time to complete.
This PR adds an explicit reroute to ensure the latest cluster info is
picked up.

Resolves: elastic#116870
@ywangd ywangd mentioned this issue Nov 18, 2024
Merged
@ywangd ywangd closed this as completed in c32b300 Nov 18, 2024
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this issue Nov 18, 2024
@elasticsearchmachine @salvatore-campagna
Mute org.elasticsearch.cluster.routing.allocation.allocator.DesiredBa…
d4f92b4 
…lanceReconcilerMetricsIT testDesiredBalanceMetrics elastic#116870
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this issue Nov 18, 2024
@ywangd @salvatore-campagna
[Test] Ensure latest cluster info is used in tests (elastic#116908)
12a4c42 
DesiredBalanceMetrics#updateMetrics is called on reroute which is
frequent but not guaranteed. It can also take some time to complete.
This PR adds an explicit reroute to ensure the latest cluster info is
picked up.

Resolves: elastic#116870
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
@elasticsearchmachine @alexey-ivanov-es
Mute org.elasticsearch.cluster.routing.allocation.allocator.DesiredBa…
98d75af 
…lanceReconcilerMetricsIT testDesiredBalanceMetrics elastic#116870
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
@ywangd @alexey-ivanov-es
[Test] Ensure latest cluster info is used in tests (elastic#116908)
906de15 
DesiredBalanceMetrics#updateMetrics is called on reroute which is
frequent but not guaranteed. It can also take some time to complete.
This PR adds an explicit reroute to ensure the latest cluster info is
picked up.

Resolves: elastic#116870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywangd ywangd

Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) low-risk An open issue or test failure that is a low risk to future releases Team:Distributed Coordination Meta label for Distributed Coordination team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Test] Ensure latest cluster info is used in tests ywangd/elasticsearch
2 participants
@ywangd @elasticsearchmachine