Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BaseNodesRequest#writeTo final #109783

Merged

Conversation

DaveCTurner
Copy link
Contributor

Since #109682 these requests are never sent or received over the wire,
so we can drop all their writeTo implementations and forbid new
actions from going over the wire by making the base class writeTo
method final.

Closes #100878

Since elastic#109682 these requests are never sent or received over the wire,
so we can drop all their `writeTo` implementations and forbid new
actions from going over the wire by making the base class `writeTo`
method final.

Closes elastic#100878
@DaveCTurner DaveCTurner added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.15.0 labels Jun 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jun 17, 2024
@DaveCTurner DaveCTurner requested a review from ywangd June 17, 2024 05:29
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit 5e191a0 into elastic:main Jun 17, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/06/17/BaseNodesRequest-writeTo-final branch June 17, 2024 05:50
@DaveCTurner DaveCTurner restored the 2024/06/17/BaseNodesRequest-writeTo-final branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not send full top-level TransportNodesAction request to individual nodes
3 participants