Skip BaseNodesRequest header without instantiation
#109682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in elastic#100878 we sometimes send an unnecessary wrapped-up `BaseNodesRequest` to individual nodes for legacy reasons, and today we do that by calling its constructor and then discarding the resulting object. This commit introduces utilities for skipping and synthesizing the unnecessary data without involving `BaseNodesRequest` itself.
DaveCTurner
added
>non-issue
:Distributed Indexing/Distributed
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
…sRequest-skip-header
14 tasks
ywangd
approved these changes
Jun 17, 2024
Comment on lines
-49
to
-57
| @Deprecated(forRemoval = true) | ||
| protected BaseNodesRequest(StreamInput in) throws IOException { | ||
| // A bare `BaseNodesRequest` is never sent over the wire, but several implementations send the full top-level request to each node | ||
| // (wrapped up in another request). They shouldn't, but until we fix that we must keep this. See #100878. | ||
| super(in); | ||
| nodesIds = in.readStringArray(); | ||
| concreteNodes = in.readOptionalArray(DiscoveryNode::new, DiscoveryNode[]::new); | ||
| timeout = in.readOptionalTimeValue(); | ||
| } |
There was a problem hiding this comment.
Should we replace its writeTo method implementation with localOnly?
There was a problem hiding this comment.
Yes, that's incoming in a follow-up.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 17, 2024
Since elastic#109682 these requests are never sent or received over the wire, so we can drop all their `writeTo` implementations and forbid new actions from going over the wire by making the base class `writeTo` method final. Closes elastic#100878
DaveCTurner
added a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #100878 we sometimes send an unnecessary wrapped-up
BaseNodesRequestto individual nodes for legacy reasons, and today wedo that by calling its constructor and then discarding the resulting
object. This commit introduces utilities for skipping and synthesizing
the unnecessary data without involving
BaseNodesRequestitself.