Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require 'capabilities' test runner feature if using capabilities check #108678

Merged
merged 1 commit into from
May 16, 2024
Merged

Require 'capabilities' test runner feature if using capabilities check #108678

merged 1 commit into from
May 16, 2024
+34 −3

Conversation

mosche
Copy link
Contributor

@mosche mosche commented May 15, 2024

Require 'capabilities' test runner feature if using capabilities check introduced in #108425.

cc @elastic/clients-team

@mosche mosche added :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests labels May 15, 2024
@mosche mosche requested a review from a team May 15, 2024 13:20
@mosche mosche marked this pull request as ready for review May 15, 2024 17:57
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mosche mosche mentioned this pull request May 16, 2024
Merged
ldematte
ldematte approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a check: we are introducing this on all tests that we already switched to _capabilities, right?

@mosche
Copy link
Contributor Author

mosche commented May 16, 2024

we are introducing this on all tests that we already switched to _capabilities, right?

yes, so far just the example one for capabilities itself

@mosche mosche merged commit fd2ba45 into elastic:main May 16, 2024
15 checks passed
@mosche mosche deleted the yaml_capabilities_test_runner_feature branch May 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldematte ldematte ldematte approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mosche @elasticsearchmachine @ldematte