-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose capability checks for YAML REST tests #108425
Conversation
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
I've added an That does mean that the response can be either a string or a boolean - not great. The alternatives are:
We also need to consider what clients will do if a node temporarily goes unavailable, resulting in all capability queries returning |
Decision - return |
Thanks @thecoop , the changes are looking good to me 💯 |
I've changed this to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, @mosche merge if you are
This PR adds support to check capabilities both in the
skip
andrequires
section on YAML REST tests.See here for an example: