[Inference API] Avoid potential flaky wire serialization test cases

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/EmptyTaskSettingsTests.java

@@ -29,6 +29,7 @@ protected EmptyTaskSettings createTestInstance() {
 
     @Override
     protected EmptyTaskSettings mutateInstance(EmptyTaskSettings instance) {
+        // All instances are the same and have no fields, nothing to mutate
         return null;
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/action/InferenceActionResponseTests.java

@@ -53,7 +53,7 @@ protected InferenceAction.Response createTestInstance() {
 
     @Override
     protected InferenceAction.Response mutateInstance(InferenceAction.Response instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, this::createTestInstance);
     }
 
     @Override

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/results/ChunkedSparseEmbeddingResultsTests.java

@@ -132,6 +132,6 @@ protected ChunkedSparseEmbeddingResults createTestInstance() {
 
     @Override
     protected ChunkedSparseEmbeddingResults mutateInstance(ChunkedSparseEmbeddingResults instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, ChunkedSparseEmbeddingResultsTests::createRandomResults);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/results/ChunkedTextEmbeddingByteResultsTests.java

@@ -131,6 +131,6 @@ protected ChunkedTextEmbeddingByteResults createTestInstance() {
 
     @Override
     protected ChunkedTextEmbeddingByteResults mutateInstance(ChunkedTextEmbeddingByteResults instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, ChunkedTextEmbeddingByteResultsTests::createRandomResults);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/results/ChunkedTextEmbeddingFloatResultsTests.java

@@ -51,6 +51,6 @@ protected ChunkedTextEmbeddingFloatResults createTestInstance() {
 
     @Override
     protected ChunkedTextEmbeddingFloatResults mutateInstance(ChunkedTextEmbeddingFloatResults instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, this::createTestInstance);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/results/ChunkedTextEmbeddingResultsTests.java

@@ -159,6 +159,6 @@ protected ChunkedTextEmbeddingResults createTestInstance() {
 
     @Override
     protected ChunkedTextEmbeddingResults mutateInstance(ChunkedTextEmbeddingResults instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, ChunkedTextEmbeddingResultsTests::createRandomResults);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureopenai/AzureOpenAiSecretSettingsTests.java

@@ -143,7 +143,7 @@ protected AzureOpenAiSecretSettings createTestInstance() {
 
     @Override
     protected AzureOpenAiSecretSettings mutateInstance(AzureOpenAiSecretSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, AzureOpenAiSecretSettingsTests::createRandom);
     }
 
     public static Map<String, Object> getAzureOpenAiSecretSettingsMap(@Nullable String apiKey, @Nullable String entraId) {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureopenai/completion/AzureOpenAiCompletionServiceSettingsTests.java

@@ -87,6 +87,6 @@ protected AzureOpenAiCompletionServiceSettings createTestInstance() {
 
     @Override
     protected AzureOpenAiCompletionServiceSettings mutateInstance(AzureOpenAiCompletionServiceSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, AzureOpenAiCompletionServiceSettingsTests::createRandom);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureopenai/completion/AzureOpenAiCompletionTaskSettingsTests.java

@@ -94,6 +94,6 @@ protected AzureOpenAiCompletionTaskSettings createTestInstance() {
 
     @Override
     protected AzureOpenAiCompletionTaskSettings mutateInstance(AzureOpenAiCompletionTaskSettings instance) throws IOException {
-        return createRandomWithUser();
+        return randomValueOtherThan(instance, AzureOpenAiCompletionTaskSettingsTests::createRandomWithUser);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureopenai/embeddings/AzureOpenAiEmbeddingsServiceSettingsTests.java

@@ -423,7 +423,7 @@ protected AzureOpenAiEmbeddingsServiceSettings createTestInstance() {
 
     @Override
     protected AzureOpenAiEmbeddingsServiceSettings mutateInstance(AzureOpenAiEmbeddingsServiceSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, AzureOpenAiEmbeddingsServiceSettingsTests::createRandom);
     }
 
     public static Map<String, Object> getPersistentAzureOpenAiServiceSettingsMap(

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/azureopenai/embeddings/AzureOpenAiEmbeddingsTaskSettingsTests.java

@@ -92,7 +92,7 @@ protected AzureOpenAiEmbeddingsTaskSettings createTestInstance() {
 
     @Override
     protected AzureOpenAiEmbeddingsTaskSettings mutateInstance(AzureOpenAiEmbeddingsTaskSettings instance) throws IOException {
-        return createRandomWithUser();
+        return randomValueOtherThan(instance, AzureOpenAiEmbeddingsTaskSettingsTests::createRandomWithUser);
     }
 
     public static Map<String, Object> getAzureOpenAiRequestTaskSettingsMap(@Nullable String user) {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/CohereServiceSettingsTests.java

@@ -275,7 +275,7 @@ protected CohereServiceSettings createTestInstance() {
 
     @Override
     protected CohereServiceSettings mutateInstance(CohereServiceSettings instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, CohereServiceSettingsTests::createRandom);
     }
 
     public static Map<String, Object> getServiceSettingsMap(@Nullable String url, @Nullable String model) {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/embeddings/CohereEmbeddingsServiceSettingsTests.java

@@ -358,7 +358,7 @@ protected CohereEmbeddingsServiceSettings createTestInstance() {
 
     @Override
     protected CohereEmbeddingsServiceSettings mutateInstance(CohereEmbeddingsServiceSettings instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, CohereEmbeddingsServiceSettingsTests::createRandom);
     }
 
     @Override

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/embeddings/CohereEmbeddingsTaskSettingsTests.java

@@ -156,7 +156,7 @@ protected CohereEmbeddingsTaskSettings createTestInstance() {
 
     @Override
     protected CohereEmbeddingsTaskSettings mutateInstance(CohereEmbeddingsTaskSettings instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, CohereEmbeddingsTaskSettingsTests::createRandom);
     }
 
     public static Map<String, Object> getTaskSettingsMapEmpty() {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/rerank/CohereRerankServiceSettingsTests.java

@@ -77,7 +77,7 @@ protected CohereRerankServiceSettings createTestInstance() {
 
     @Override
     protected CohereRerankServiceSettings mutateInstance(CohereRerankServiceSettings instance) throws IOException {
-        return null;
+        return randomValueOtherThan(instance, CohereRerankServiceSettingsTests::createRandom);
     }
 
     @Override

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceServiceSettingsTests.java

@@ -197,7 +197,7 @@ protected HuggingFaceServiceSettings createTestInstance() {
 
     @Override
     protected HuggingFaceServiceSettings mutateInstance(HuggingFaceServiceSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, HuggingFaceServiceSettingsTests::createRandom);
     }
 
     public static Map<String, Object> getServiceSettingsMap(String url) {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/huggingface/elser/HuggingFaceElserSecretSettingsTests.java

@@ -77,6 +77,6 @@ protected HuggingFaceElserSecretSettings createTestInstance() {
 
     @Override
     protected HuggingFaceElserSecretSettings mutateInstance(HuggingFaceElserSecretSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, HuggingFaceElserSecretSettingsTests::createRandom);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/huggingface/elser/HuggingFaceElserServiceSettingsTests.java

@@ -122,6 +122,6 @@ protected HuggingFaceElserServiceSettings createTestInstance() {
 
     @Override
     protected HuggingFaceElserServiceSettings mutateInstance(HuggingFaceElserServiceSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, HuggingFaceElserServiceSettingsTests::createRandom);
     }
 }

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/openai/completion/OpenAiChatCompletionServiceSettingsTests.java

@@ -236,7 +236,7 @@ protected OpenAiChatCompletionServiceSettings createTestInstance() {
 
     @Override
     protected OpenAiChatCompletionServiceSettings mutateInstance(OpenAiChatCompletionServiceSettings instance) throws IOException {
-        return createRandomWithNonNullUrl();
+        return randomValueOtherThan(instance, OpenAiChatCompletionServiceSettingsTests::createRandomWithNonNullUrl);
     }
 
     private static OpenAiChatCompletionServiceSettings createRandomWithNonNullUrl() {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/openai/embeddings/OpenAiEmbeddingsServiceSettingsTests.java

@@ -441,7 +441,7 @@ protected OpenAiEmbeddingsServiceSettings createTestInstance() {
 
     @Override
     protected OpenAiEmbeddingsServiceSettings mutateInstance(OpenAiEmbeddingsServiceSettings instance) throws IOException {
-        return createRandomWithNonNullUrl();
+        return randomValueOtherThan(instance, OpenAiEmbeddingsServiceSettingsTests::createRandomWithNonNullUrl);
     }
 
     public static Map<String, Object> getServiceSettingsMap(String modelId, @Nullable String url, @Nullable String org) {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/openai/embeddings/OpenAiEmbeddingsTaskSettingsTests.java

@@ -97,7 +97,7 @@ protected OpenAiEmbeddingsTaskSettings createTestInstance() {
 
     @Override
     protected OpenAiEmbeddingsTaskSettings mutateInstance(OpenAiEmbeddingsTaskSettings instance) throws IOException {
-        return createRandomWithUser();
+        return randomValueOtherThan(instance, OpenAiEmbeddingsTaskSettingsTests::createRandomWithUser);
     }
 
     public static Map<String, Object> getTaskSettingsMap(@Nullable String user) {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/settings/DefaultSecretSettingsTests.java

@@ -75,7 +75,7 @@ protected DefaultSecretSettings createTestInstance() {
 
     @Override
     protected DefaultSecretSettings mutateInstance(DefaultSecretSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, DefaultSecretSettingsTests::createRandom);
     }
 
     public static Map<String, Object> getSecretSettingsMap(String apiKey) {

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/settings/RateLimitSettingsTests.java

@@ -100,6 +100,6 @@ protected RateLimitSettings createTestInstance() {
 
     @Override
     protected RateLimitSettings mutateInstance(RateLimitSettings instance) throws IOException {
-        return createRandom();
+        return randomValueOtherThan(instance, RateLimitSettingsTests::createRandom);
     }
 }