[Inference API] Avoid potential flaky wire serialization test cases #108605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIU there's some small likelihood for
createTestInstance
andmutateInstance
to return two equal instances if you don't wrapcreateRandom
calls withrandomValueOtherThan
, which would lead to a flaky test failure. I've adjusted this for all wire serialization test cases and also implementedmutateInstance
wherenull
was returned. Some of these classes were records, so we strictly don't need to test this, but we already had instances, where we've converted arecord
to aclass
and implementedequals
andhashCode
again manually, so preempting this.