Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Release test resources #107057

Merged
merged 3 commits into from
Apr 10, 2024
Merged

[Transform] Release test resources #107057

merged 3 commits into from
Apr 10, 2024

Conversation

prwhelan
Copy link
Member

@prwhelan prwhelan commented Apr 3, 2024

Consume the HttpEntity after the API response is parsed, releasing network and thread resources back to their respective pools.

Leaving them unconsumed does not appear to be causing issues during tests, but it does log a large amount of hanging threads on test failure, making it harder to spot what may be the issue when a thread is hanging during a transform test.

Close #107055

Consume the HttpEntity after the API response is parsed, releasing
network and thread resources back to their respective pools.

Leaving them unconsumed does not appear to be causing issues during
tests, but it does log a large amount of hanging threads on test
failure, making it harder to spot what may be the issue when a thread is
hanging during a transform test.

Close elastic#107055
@prwhelan prwhelan added >test Issues or PRs that are addressing/adding tests :ml/Transform Transform Team:ML Meta label for the ML team labels Apr 3, 2024
@prwhelan prwhelan marked this pull request as ready for review April 3, 2024 15:32
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prwhelan
Copy link
Member Author

prwhelan commented Apr 5, 2024

@elasticmachine update branch

@elasticmachine
Copy link
Collaborator

merge conflict between base and head

@prwhelan prwhelan merged commit b3bcc81 into elastic:main Apr 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transform] Release test resources during test execution
4 participants