Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Release test resources during test execution #107055

Closed
prwhelan opened this issue Apr 3, 2024 · 1 comment · Fixed by #107057
Closed

[Transform] Release test resources during test execution #107055

prwhelan opened this issue Apr 3, 2024 · 1 comment · Fixed by #107057
Assignees
Labels
:ml/Transform Transform Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.14.0

Comments

@prwhelan
Copy link
Member

prwhelan commented Apr 3, 2024

Description

While debugging test failures, there are a number of threads and connections hanging waiting to be released. This is likely due to the InputStream not being closed. This could potentially slow down tests when the full suite is run, but more likely it's just causing noise in the logs when there is a failure.

@prwhelan prwhelan added >test Issues or PRs that are addressing/adding tests :ml/Transform Transform Team:ML Meta label for the ML team v8.14.0 labels Apr 3, 2024
@prwhelan prwhelan self-assigned this Apr 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

prwhelan added a commit to prwhelan/elasticsearch that referenced this issue Apr 3, 2024
Consume the HttpEntity after the API response is parsed, releasing
network and thread resources back to their respective pools.

Leaving them unconsumed does not appear to be causing issues during
tests, but it does log a large amount of hanging threads on test
failure, making it harder to spot what may be the issue when a thread is
hanging during a transform test.

Close elastic#107055
prwhelan added a commit that referenced this issue Apr 10, 2024
Consume the HttpEntity after the API response is parsed, releasing
network and thread resources back to their respective pools.

Leaving them unconsumed does not appear to be causing issues during
tests, but it does log a large amount of hanging threads on test
failure, making it harder to spot what may be the issue when a thread is
hanging during a transform test.

Close #107055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.14.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants