Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial metrics for synthetic source #106732
Added initial metrics for synthetic source #106732
Changes from 11 commits
906bc40
11331b8
f036fe6
e4dcbcd
12b5563
1d6baa4
38b307f
ef6a1d5
fe03388
d40d8eb
a4516a2
87133c7
75daad1
0b6d538
492b751
313e479
843d670
c412203
d9b57b3
bf0d559
fa497e0
84f44d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the use of
ValueWithThreadLocalOverride
isn't needed? I thinkThreadLocal.withInitial(...)
can be used here that reads from a static field. Then the test just changes the NOOP static field to point to another instance. Additionally the init method can be changed to update NOOP instance?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a test changes static field it potentially impacts other concurrent test using this static field. That is the main idea behind
ValueWithThreadLocalOverride
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOOP
here is indeed a leftover from previous implementation.