-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial metrics for synthetic source #106732
Changes from all commits
906bc40
11331b8
f036fe6
e4dcbcd
12b5563
1d6baa4
38b307f
ef6a1d5
fe03388
d40d8eb
a4516a2
87133c7
75daad1
0b6d538
492b751
313e479
843d670
c412203
d9b57b3
bf0d559
fa497e0
84f44d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
package org.elasticsearch.index.mapper; | ||
|
||
/** | ||
* Groups together all metrics used in mappers. | ||
* Main purpose of this class is to avoid verbosity of passing individual metric instances around. | ||
*/ | ||
public record MapperMetrics(SourceFieldMetrics sourceFieldMetrics) { | ||
public static MapperMetrics NOOP = new MapperMetrics(SourceFieldMetrics.NOOP); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are this There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Almost - it is used in benchmarks too. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see, maybe then let's keep it here. |
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should make this even more generic given that it is now in
SearchExecutionContext
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but I'd use a container like
SearchExecutionMetrics
to the context and includeMapperMetrics
in it.