-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust mute for particular condition for 106647 #106675
Adjust mute for particular condition for 106647 #106675
Conversation
Pinging @elastic/es-search (Team:Search) |
@javanna I am just going to close this as you expressed interest in fixing this yourself in a different way. |
I meant to review this and better understand it, but I had no spare cycles yet. Did not necessarily have a different approach in mind. I had the feeling that we may be hiding bugs by adjusting the code, that's it. |
@elasticmachine update branch |
@elasticmachine update branch |
@elasticmachine update branch |
The test failure occurs when we have a
threshold
. Even when only gathering a single document for a query, because of this line:We will check for earlyTermination even if the leaf has no matching docs. But, this is expected by other tests.
This does a partial unmute allowing for the test to run, but acknowledging we have a strange edge case here that conflicts the expected results for two of our tests:
testCollectedHitCount()
when threshold==1 vstestEarlyTerminatesWithoutCollection()