Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] PartialHitCountCollectorTests testCollectedHitCount failing #106647

Closed
ldematte opened this issue Mar 22, 2024 · 4 comments · Fixed by #116181
Closed

[CI] PartialHitCountCollectorTests testCollectedHitCount failing #106647

ldematte opened this issue Mar 22, 2024 · 4 comments · Fixed by #116181
Assignees
@javanna
Labels
low-risk An open issue or test failure that is a low risk to future releases :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@ldematte
Copy link
Contributor

Reproduces with ./gradlew ':server:test' --tests "org.elasticsearch.search.query.PartialHitCountCollectorTests.testCollectedHitCount" -Dtests.seed=4DAD7A6F655975F4 -Dtests.locale=es-CU -Dtests.timezone=America/Rio_Branco -Druntime.java=21

Build scan:
https://gradle-enterprise.elastic.co/s/gktrvnkxedbgk/tests/:server:test/org.elasticsearch.search.query.PartialHitCountCollectorTests/testCollectedHitCount

Reproduction line:

./gradlew ':server:test' --tests "org.elasticsearch.search.query.PartialHitCountCollectorTests.testCollectedHitCount" -Dtests.seed=4DAD7A6F655975F4 -Dtests.locale=es-CU -Dtests.timezone=America/Rio_Branco -Druntime.java=21

Applicable branches:
8.12

Reproduces locally?:
Yes

Failure history:
Failure dashboard for org.elasticsearch.search.query.PartialHitCountCollectorTests#testCollectedHitCount

Failure excerpt:

java.lang.AssertionError: (No message provided)

  at __randomizedtesting.SeedInfo.seed([4DAD7A6F655975F4:86F44693FDEA5D2C]:0)
  at org.junit.Assert.fail(Assert.java:86)
  at org.junit.Assert.assertTrue(Assert.java:41)
  at org.junit.Assert.assertFalse(Assert.java:64)
  at org.junit.Assert.assertFalse(Assert.java:74)
  at org.elasticsearch.search.query.PartialHitCountCollectorTests.testCollectedHitCount(PartialHitCountCollectorTests.java:128)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)
@ldematte ldematte added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels Mar 22, 2024
@elasticsearchmachine elasticsearchmachine added blocker Team:Search Meta label for search team labels Mar 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@benwtrent benwtrent self-assigned this Mar 22, 2024
@benwtrent
Copy link
Member

Yeah, this is repeatable, gonna mute.

benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 22, 2024
@benwtrent
Test mute for issue elastic#106647
a428d0a
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 22, 2024
@benwtrent
Test mute for issue elastic#106647
c09bd34
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 22, 2024
@benwtrent
Test mute for issue elastic#106647
d08e840
@benwtrent
Copy link
Member

OK, I changed the test to

int threshold = 1;

And this reliably fails every time. I am guessing our check isn't actually >= or we have a weird fence-post error.

elasticsearchmachine pushed a commit that referenced this issue Mar 22, 2024
@benwtrent
Test mute for issue #106647 (#106670)
bd6f3c7
elasticsearchmachine pushed a commit that referenced this issue Mar 22, 2024
@benwtrent
Test mute for issue #106647 (#106671)
7de0c3d
elasticsearchmachine pushed a commit that referenced this issue Mar 22, 2024
@benwtrent
Test mute for issue #106647 (#106672)
ae3662b
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Mar 22, 2024
@benwtrent
Fix test failure elastic#106647
d3fa101
@benwtrent benwtrent added low-risk An open issue or test failure that is a low risk to future releases and removed blocker labels Mar 22, 2024
@benwtrent benwtrent mentioned this issue Mar 22, 2024
Merged
This was referenced Mar 25, 2024
Merged
Merged
@benwtrent benwtrent removed their assignment May 1, 2024
@javanna javanna removed the :Search/Search Search-related issues that do not fall into other categories label Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label and removed Team:Search Meta label for search team labels Jul 17, 2024
@javanna javanna added :Search Foundations/Search Catch all for Search Foundations and removed needs:triage Requires assignment of a team area label labels Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@javanna javanna self-assigned this Nov 1, 2024
javanna added a commit to javanna/elasticsearch that referenced this issue Nov 1, 2024
@javanna
[TEST] Adjust PartialHitCountCollectorTests#testCollectedHitCount
6bb9df0 
Moved the test to not verify the behaviour with terminate_after set to 1 when there is a single doc matching.
Added a comment that explains the nuance around the behaviour and what influences it.

Closes elastic#106647
@javanna javanna mentioned this issue Nov 4, 2024
Merged
javanna added a commit that referenced this issue Nov 5, 2024
@javanna
[TEST] Adjust PartialHitCountCollectorTests#testCollectedHitCount (#1…
8f55168 
…16181)

Split the test in two, one to verify behaviour with threashold greather than 1. Wrote a specific test for the edge case of threshold set to 1. Added a comment that explains the nuance around the behaviour and what influences it.

Closes #106647
javanna added a commit to javanna/elasticsearch that referenced this issue Nov 5, 2024
@javanna
[TEST] Adjust PartialHitCountCollectorTests#testCollectedHitCount (el…
ce48610 
…astic#116181)

Split the test in two, one to verify behaviour with threashold greather than 1. Wrote a specific test for the edge case of threshold set to 1. Added a comment that explains the nuance around the behaviour and what influences it.

Closes elastic#106647
elasticsearchmachine pushed a commit that referenced this issue Nov 5, 2024
@javanna
[TEST] Adjust PartialHitCountCollectorTests#testCollectedHitCount (#1…
942d0e5 
…16181) (#116243)

Split the test in two, one to verify behaviour with threashold greather than 1. Wrote a specific test for the edge case of threshold set to 1. Added a comment that explains the nuance around the behaviour and what influences it.

Closes #106647
jozala pushed a commit that referenced this issue Nov 13, 2024
@javanna @jozala
[TEST] Adjust PartialHitCountCollectorTests#testCollectedHitCount (#1…
1e2f492 
…16181)

Split the test in two, one to verify behaviour with threashold greather than 1. Wrote a specific test for the edge case of threshold set to 1. Added a comment that explains the nuance around the behaviour and what influences it.

Closes #106647
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this issue Nov 28, 2024
@javanna @alexey-ivanov-es
[TEST] Adjust PartialHitCountCollectorTests#testCollectedHitCount (el…
1d05ce8 
…astic#116181)

Split the test in two, one to verify behaviour with threashold greather than 1. Wrote a specific test for the edge case of threshold set to 1. Added a comment that explains the nuance around the behaviour and what influences it.

Closes elastic#106647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
low-risk An open issue or test failure that is a low risk to future releases :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TEST] Adjust PartialHitCountCollectorTests#testCollectedHitCount javanna/elasticsearch
4 participants
@javanna @ldematte @benwtrent @elasticsearchmachine