[Profiling] Allow wildcards for custom indices #105372
Conversation
Several profiling APIs allow to specify custom event indices with the `indices` parameter. So far this parameter has allowed only one index and also disallowed wildcards. With this commit we extend this parameter to support multiple indices and each index can use wildcards.
danielmitterdorfer
added
>non-issue
cloud-deploy
elasticsearchmachine
added
the
Team:obs-knowledge
|
Pinging @elastic/obs-knowledge-team (Team:obs-knowledge) |
|
Note: I'm labeling this as non-issue as the respective API is exclusive to Kibana and it is not yet in use. |
| @@ -32,7 +35,7 @@ | |||
| /** | |||
| * A request to get profiling details | |||
| */ | |||
| public class GetStackTracesRequest extends ActionRequest implements IndicesRequest { | |||
| public class GetStackTracesRequest extends ActionRequest implements IndicesRequest.Replaceable { | |||
There was a problem hiding this comment.
Implementing IndicesRequest.Replaceable indicates to infrastructure in Elasticsearch that we want to support wildcards, see also
| ); | ||
| } | ||
| } | ||
| return indices.toArray(new String[0]); |
There was a problem hiding this comment.
Should the String array be pre-allocated with indices.size()?
There was a problem hiding this comment.
That's actually the preferred style in Java, see also https://github.com/JetBrains/intellij-community/blob/master/java/java-impl/src/inspectionDescriptions/ToArrayCallWithZeroLengthArrayArgument.html for the rationale.
| @@ -330,7 +350,7 @@ public String[] indices() { | |||
| if (this.indices == null) { | |||
| indices.addAll(EventsIndex.indexNames()); | |||
| } else { | |||
| indices.add(this.indices); | |||
| indices.addAll(List.of(this.indices)); | |||
| } | |||
| return indices.toArray(new String[0]); | |||
There was a problem hiding this comment.
Maybe use pre-allocation here as well?
There was a problem hiding this comment.
That's actually the preferred style in Java, see also https://github.com/JetBrains/intellij-community/blob/master/java/java-impl/src/inspectionDescriptions/ToArrayCallWithZeroLengthArrayArgument.html for the rationale.
As we set indices now internally in all cases due to wildcard resolution, we need a means to distinguish whether `indices` have been provided originally via the API or whether Elasticsearch has set them internally after wildcard resolution.
Several profiling APIs allow to specify custom event indices with the
indicesparameter. So far this parameter has allowed only one index and also disallowed wildcards. With this commit we extend this parameter to support multiple indices and each index can use wildcards.