Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Show Universal Profiling on Transaction view #176302

Merged
merged 21 commits into from
Feb 13, 2024
Merged

[APM] Show Universal Profiling on Transaction view #176302

merged 21 commits into from
Feb 13, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Feb 6, 2024 •
edited
Loading

New Setting: Default value is False
Screenshot 2024-02-08 at 15 06 43

Screenshot 2024-02-08 at 14 59 17 Screenshot 2024-02-08 at 14 59 33

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes marked this pull request as ready for review February 8, 2024 15:01
@cauemarcondes cauemarcondes requested review from a team as code owners February 8, 2024 15:01
@cauemarcondes cauemarcondes changed the title Apm profiling integration v2 [APM] Show U Feb 8, 2024
@cauemarcondes cauemarcondes changed the title [APM] Show U [APM] Show Universal Profiling on Transaction view Feb 8, 2024
@cauemarcondes cauemarcondes added release_note:feature Makes this part of the condensed release notes v8.13.0 labels Feb 8, 2024
@cauemarcondes cauemarcondes requested review from a team as code owners February 8, 2024 15:03
@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Feb 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@cauemarcondes cauemarcondes requested a review from a team as a code owner February 8, 2024 16:56
@jennypavlova jennypavlova self-requested a review February 9, 2024 10:38
@neptunian
Copy link
Contributor

neptunian commented Feb 9, 2024 •
edited
Loading

Could you update the description or link to the original issue? Not sure what I'm reviewing 😃

Think I get the idea now :). Could you add a wee bit more detail in the future? Summary of changes or code comments, testing instructions, etc would be helpful for reviewers. Thanks!

@cauemarcondes
Copy link
Contributor Author

Think I get the idea now :). Could you add a wee bit more detail in the future? Summary of changes or code comments, testing instructions, etc would be helpful for reviewers. Thanks!

The issue is on a private repository, that's why I didn't like it here.
And regarding testing instructions, It took me many hours to have it working on my local setup as this feature depends on changes on ES/APM-Server/Apm-integrations. Describing every step here would be overwhelming.

@cauemarcondes cauemarcondes enabled auto-merge (squash) February 12, 2024 16:10
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiAssistantManagementObservability 76 77 +1
aiAssistantManagementSelection 62 63 +1
apm 1608 1615 +7
datasetQuality 138 139 +1
infra 1423 1424 +1
logsExplorer 672 673 +1
logsShared 222 223 +1
observability 595 596 +1
observabilityAIAssistant 244 245 +1
observabilityLogsExplorer 197 198 +1
observabilityOnboarding 195 196 +1
profiling 279 280 +1
securitySolution 4970 4971 +1
serverlessObservability 35 36 +1
ux 175 176 +1
total +21

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/io-ts-utils 58 59 +1
observability 624 631 +7
total +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +3.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 102.7KB 102.8KB +146.0B
Unknown metric groups

API count

id before after diff
@kbn/io-ts-utils 58 59 +1
observability 633 640 +7
total +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit db08fb5 into elastic:main Feb 13, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 13, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@cauemarcondes @CoenWarmer
[APM] Show Universal Profiling on Transaction view (elastic#176302)
0b236dc 
New Setting: Default value is `False`
<img width="1070" alt="Screenshot 2024-02-08 at 15 06 43"
src="https://github.com/elastic/kibana/assets/55978943/46e8273c-4389-4de5-8b93-77d3e7a191d8">
---
<img width="1335" alt="Screenshot 2024-02-08 at 14 59 17"
src="https://github.com/elastic/kibana/assets/55978943/45531abc-1c1c-4525-a2dc-b7573f857fa6">
<img width="1339" alt="Screenshot 2024-02-08 at 14 59 33"
src="https://github.com/elastic/kibana/assets/55978943/d0ca0c7e-d33e-4f4a-83d4-70ef96b2bf1b">
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@cauemarcondes @fkanout
[APM] Show Universal Profiling on Transaction view (elastic#176302)
3e9187e 
New Setting: Default value is `False`
<img width="1070" alt="Screenshot 2024-02-08 at 15 06 43"
src="https://github.com/elastic/kibana/assets/55978943/46e8273c-4389-4de5-8b93-77d3e7a191d8">
---
<img width="1335" alt="Screenshot 2024-02-08 at 14 59 17"
src="https://github.com/elastic/kibana/assets/55978943/45531abc-1c1c-4525-a2dc-b7573f857fa6">
<img width="1339" alt="Screenshot 2024-02-08 at 14 59 33"
src="https://github.com/elastic/kibana/assets/55978943/d0ca0c7e-d33e-4f4a-83d4-70ef96b2bf1b">
@cauemarcondes cauemarcondes deleted the apm-profiling-integration-v2 branch March 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@kpatticha kpatticha kpatticha approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

@jennypavlova jennypavlova Awaiting requested review from jennypavlova

@neptunian neptunian Awaiting requested review from neptunian

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:build-cloud-image release_note:feature Makes this part of the condensed release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.