[CI] Ensure large response can fit into 3 messages #104729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower the upper bound of large response size from 2 times of suggestedMaxAllocationSize to 1.5 so that it be sent over with 3 messages. This is because the split threshold is 0.99 of suggestedMaxAllocationSize. Resolves: elastic#104728
ywangd
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywangd
commented
Jan 25, 2024
| public void testLargeFullResponsesAreSplit() { | ||
| final List<Object> messagesSeen = new ArrayList<>(); | ||
| final var embeddedChannel = new EmbeddedChannel(capturingHandler(messagesSeen), getTestHttpHandler()); | ||
| embeddedChannel.writeInbound(createHttpRequest("/test")); | ||
| final Netty4HttpRequest request = embeddedChannel.readInbound(); | ||
| final var minSize = (int) NettyAllocator.suggestedMaxAllocationSize(); | ||
| final var content = new ZeroBytesReference(between(minSize, minSize * 2)); | ||
| final var content = new ZeroBytesReference(between(minSize, (int) (minSize * 1.5))); |
There was a problem hiding this comment.
I chose 1.5 as the upper bound since testSmallFullResponsesAreSentDirectly uses 0.5 as the upper bound.
DaveCTurner
approved these changes
Jan 25, 2024
henningandersen
pushed a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jan 25, 2024
Lower the upper bound of large response size from 2 times of suggestedMaxAllocationSize to 1.5 so that it be sent over with 3 messages. This is because the split threshold is 0.99 of suggestedMaxAllocationSize. Resolves: elastic#104728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower the upper bound of large response size from
2 times of suggestedMaxAllocationSize to 1.5 so that it be sent over with 3 messages. This is because the split threshold is 0.99 of suggestedMaxAllocationSize.
Resolves: #104728