Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Netty4HttpPipeliningHandlerTests testLargeFullResponsesAreSplit failing #104728

Closed
mark-vieira opened this issue Jan 24, 2024 · 3 comments · Fixed by #104729
Closed

[CI] Netty4HttpPipeliningHandlerTests testLargeFullResponsesAreSplit failing #104728

mark-vieira opened this issue Jan 24, 2024 · 3 comments · Fixed by #104729
Labels
:Distributed Coordination/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI

Comments

@mark-vieira
Copy link
Contributor

This looks to have been added in #104642 and reproduced locally for me.

Build scan:
https://gradle-enterprise.elastic.co/s/jixspoaeb4qoe/tests/:modules:transport-netty4:test/org.elasticsearch.http.netty4.Netty4HttpPipeliningHandlerTests/testLargeFullResponsesAreSplit

Reproduction line:

./gradlew ':modules:transport-netty4:test' --tests "org.elasticsearch.http.netty4.Netty4HttpPipeliningHandlerTests.testLargeFullResponsesAreSplit" -Dtests.seed=C9B5CDCE843E36CF -Dtests.locale=id-ID -Dtests.timezone=MST7MDT -Druntime.java=21

Applicable branches:
main

Reproduces locally?:
Yes

Failure history:
Failure dashboard for org.elasticsearch.http.netty4.Netty4HttpPipeliningHandlerTests#testLargeFullResponsesAreSplit

Failure excerpt:

java.lang.AssertionError: 
Expected: a collection with size <3>
     but: collection size was <4>

  at __randomizedtesting.SeedInfo.seed([C9B5CDCE843E36CF:6BF7B9DE76CC43C1]:0)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
  at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
  at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2119)
  at org.elasticsearch.http.netty4.Netty4HttpPipeliningHandlerTests.testLargeFullResponsesAreSplit(Netty4HttpPipeliningHandlerTests.java:247)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
  at java.lang.reflect.Method.invoke(Method.java:580)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1583)
@mark-vieira mark-vieira added :Distributed Coordination/Network Http and internode communication implementations >test-failure Triaged test failures from CI labels Jan 24, 2024
@elasticsearchmachine elasticsearchmachine added blocker Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Jan 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

mark-vieira added a commit that referenced this issue Jan 24, 2024
@mark-vieira
AwaitsFix #104728
9b4647c
@mark-vieira
Copy link
Contributor Author

Muted on main.

@DaveCTurner looks like you recently authored this test, mind taking a look?

ywangd added a commit to ywangd/elasticsearch that referenced this issue Jan 25, 2024
@ywangd
[CI] Ensure large response can fit into 3 messages
d055ba9 
Lower the upper bound of large response size from
2 times of suggestedMaxAllocationSize to 1.5 so that it be sent over
with 3 messages. This is because the split threshold is 0.99 of
suggestedMaxAllocationSize.

Resolves: elastic#104728
@ywangd ywangd mentioned this issue Jan 25, 2024
Merged
@ywangd ywangd added low-risk An open issue or test failure that is a low risk to future releases and removed blocker labels Jan 25, 2024
@ywangd
Copy link
Member

ywangd commented Jan 25, 2024

It is a test issue. I raised #104729

ywangd added a commit that referenced this issue Jan 25, 2024
@ywangd
[CI] Ensure large response can fit into 3 messages (#104729)
e0ddb82 
Lower the upper bound of large response size from
2 times of suggestedMaxAllocationSize to 1.5 so that it be sent over
with 3 messages. This is because the split threshold is 0.99 of
suggestedMaxAllocationSize.

Resolves: #104728
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this issue Jan 25, 2024
@mark-vieira @henningandersen
AwaitsFix elastic#104728
3443f4e
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this issue Jan 25, 2024
@ywangd @henningandersen
[CI] Ensure large response can fit into 3 messages (elastic#104729)
bf353b2 
Lower the upper bound of large response size from
2 times of suggestedMaxAllocationSize to 1.5 so that it be sent over
with 3 messages. This is because the split threshold is 0.99 of
suggestedMaxAllocationSize.

Resolves: elastic#104728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed Coordination/Network Http and internode communication implementations low-risk An open issue or test failure that is a low risk to future releases Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Ensure large response can fit into 3 messages ywangd/elasticsearch
3 participants
@ywangd @mark-vieira @elasticsearchmachine