-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert delete-by-query deprecations #10443
Changes from 2 commits
0bf0444
45bbb7a
6967372
0a1b8fc
ed86c94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,11 +27,7 @@ | |
|
||
/** | ||
* Delete by query response executed on a specific shard. | ||
* | ||
* @deprecated Delete by query will be removed in 2.0. Instead, use the scroll/scan API to find all matching IDs and then issue a bulk | ||
* request to delete them. | ||
*/ | ||
@Deprecated | ||
public class ShardDeleteByQueryResponse extends ActionResponse { | ||
|
||
@Override | ||
|
@@ -43,4 +39,4 @@ public void readFrom(StreamInput in) throws IOException { | |
public void writeTo(StreamOutput out) throws IOException { | ||
super.writeTo(out); | ||
} | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto? |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,10 +45,8 @@ | |
import org.elasticsearch.transport.TransportService; | ||
|
||
/** | ||
* @deprecated Delete by query will be removed in 2.0. Instead, use the scroll/scan API to find all matching IDs and then issue a bulk | ||
* request to delete them. | ||
* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's just remove an empty javadoc block? |
||
*/ | ||
@Deprecated | ||
public class TransportShardDeleteByQueryAction extends TransportShardReplicationOperationAction<ShardDeleteByQueryRequest, ShardDeleteByQueryRequest, ShardDeleteByQueryResponse> { | ||
|
||
public final static String DELETE_BY_QUERY_API = "delete_by_query"; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,13 +22,11 @@ | |
import org.elasticsearch.index.shard.ShardId; | ||
|
||
/** | ||
* @deprecated Delete by query will be removed in 2.0. Instead, use the scroll/scan API to find all matching IDs and then issue a bulk | ||
* request to delete them. | ||
* | ||
*/ | ||
@Deprecated | ||
public class DeleteByQueryFailedEngineException extends EngineException { | ||
|
||
public DeleteByQueryFailedEngineException(ShardId shardId, Engine.DeleteByQuery deleteByQuery, Throwable cause) { | ||
super(shardId, "Delete by query failed for [" + deleteByQuery.query() + "]", cause); | ||
} | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. another newline removal |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,10 +41,8 @@ | |
import static org.elasticsearch.rest.RestRequest.Method.DELETE; | ||
|
||
/** | ||
* @deprecated Delete by query will be removed in 2.0. Instead, use the scroll/scan API to find all matching IDs and then issue a bulk | ||
* request to delete them. | ||
* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto on removing empty comment? |
||
*/ | ||
@Deprecated | ||
public class RestDeleteByQueryAction extends BaseRestHandler { | ||
|
||
@Inject | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unintentional removal of newline?