Revert delete-by-query deprecations #10443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,4 +109,4 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| failure.writeTo(out); | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
unintentional removal of newline?
|
LGTM, just a couple very minor requests. |
|
Thanks @rjernst, I added the missing newlines, removed the empty javadocs... |
mikemccand
added a commit
that referenced
this pull request
Apr 7, 2015
mikemccand
added a commit
that referenced
this pull request
Apr 7, 2015
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
cc-pairstation
pushed a commit
to Casecommons/elasticsearch-ruby
that referenced
this pull request
Sep 21, 2017
This functionality was undeprecated in es 2.0 elastic/elasticsearch#10443 Also related: ruflin/Elastica#875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Un-deprecate delete-by-query since we will not remove it for 2.0 (#10288), but rather hopefully soon replace it with a less trappy implementation (#7052).