Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure release vector builder in QuantileStates #100693

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Ensure release vector builder in QuantileStates #100693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 40 additions & 37 deletions ...ugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/QuantileStates.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,58 +161,61 @@ TDigestState getOrNull(int position) {
@Override
public void toIntermediate(Block[] blocks, int offset, IntVector selected, DriverContext driverContext) {
assert blocks.length >= offset + 1;
var builder = BytesRefBlock.newBlockBuilder(selected.getPositionCount(), driverContext.blockFactory());
for (int i = 0; i < selected.getPositionCount(); i++) {
int group = selected.getInt(i);
TDigestState state;
if (group < digests.size()) {
state = getOrNull(group);
if (state == null) {
try (var builder = BytesRefBlock.newBlockBuilder(selected.getPositionCount(), driverContext.blockFactory())) {
for (int i = 0; i < selected.getPositionCount(); i++) {
int group = selected.getInt(i);
TDigestState state;
if (group < digests.size()) {
state = getOrNull(group);
if (state == null) {
state = TDigestState.create(DEFAULT_COMPRESSION);
}
} else {
state = TDigestState.create(DEFAULT_COMPRESSION);
}
} else {
state = TDigestState.create(DEFAULT_COMPRESSION);
builder.appendBytesRef(serializeDigest(state));
}
builder.appendBytesRef(serializeDigest(state));
blocks[offset] = builder.build();
}
blocks[offset] = builder.build();
}

Block evaluateMedianAbsoluteDeviation(IntVector selected, DriverContext driverContext) {
assert percentile == MEDIAN : "Median must be 50th percentile [percentile = " + percentile + "]";
final DoubleBlock.Builder builder = DoubleBlock.newBlockBuilder(selected.getPositionCount(), driverContext.blockFactory());
for (int i = 0; i < selected.getPositionCount(); i++) {
int si = selected.getInt(i);
if (si >= digests.size()) {
builder.appendNull();
continue;
}
final TDigestState digest = digests.get(si);
if (digest != null && digest.size() > 0) {
builder.appendDouble(InternalMedianAbsoluteDeviation.computeMedianAbsoluteDeviation(digest));
} else {
builder.appendNull();
try (DoubleBlock.Builder builder = DoubleBlock.newBlockBuilder(selected.getPositionCount(), driverContext.blockFactory())) {
for (int i = 0; i < selected.getPositionCount(); i++) {
int si = selected.getInt(i);
if (si >= digests.size()) {
builder.appendNull();
continue;
}
final TDigestState digest = digests.get(si);
if (digest != null && digest.size() > 0) {
builder.appendDouble(InternalMedianAbsoluteDeviation.computeMedianAbsoluteDeviation(digest));
} else {
builder.appendNull();
}
}
return builder.build();
}
return builder.build();
}

Block evaluatePercentile(IntVector selected, DriverContext driverContext) {
final DoubleBlock.Builder builder = DoubleBlock.newBlockBuilder(selected.getPositionCount(), driverContext.blockFactory());
for (int i = 0; i < selected.getPositionCount(); i++) {
int si = selected.getInt(i);
if (si >= digests.size()) {
builder.appendNull();
continue;
}
final TDigestState digest = digests.get(si);
if (percentile != null && digest != null && digest.size() > 0) {
builder.appendDouble(digest.quantile(percentile / 100));
} else {
builder.appendNull();
try (DoubleBlock.Builder builder = DoubleBlock.newBlockBuilder(selected.getPositionCount(), driverContext.blockFactory())) {
for (int i = 0; i < selected.getPositionCount(); i++) {
int si = selected.getInt(i);
if (si >= digests.size()) {
builder.appendNull();
continue;
}
final TDigestState digest = digests.get(si);
if (percentile != null && digest != null && digest.size() > 0) {
builder.appendDouble(digest.quantile(percentile / 100));
} else {
builder.appendNull();
}
}
return builder.build();
}
return builder.build();
}

@Override
Expand Down