Ensure release vector builder in QuantileStates #100693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>non-issue
auto-backport-and-merge
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
nik9000
approved these changes
Oct 11, 2023
|
Can we hit this with the cranky breaker somehow? I'm not sure how easy that'd be. |
Sure, I will integrate it with the cranky breaker in a follow-up. I am merging this PR to enable the ESQLBreakerIT tests. Thanks, Nik! |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Oct 11, 2023
Ensure that we always release the vector builders in case we hit the breaker in QuantileStates.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we always release the vector builders in case we hit the breaker in QuantileStates.