Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] Fix test (#100547) #100553

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[8.11] Fix test (#100547) #100553

merged 1 commit into from
Oct 9, 2023

Conversation

ChrisHegarty
Copy link
Contributor

Backports the following commits to 8.11:

@ChrisHegarty
Fix test (elastic#100547)
ac21ff8 
This commit fixes the intermittent failure of
BreakingBytesRefBuilderTests. The issue is that the test uses the
BreakingBytesRefBuilder's internal BytesRef array length to determine
whether to expect a circuit breaker exception or not. Where it should
use the builders length (not the capacity, a.k.a the internal BytesRef
array length).

The test failed intermittently about one in 10-20 runs before the
change. The test passes successfully 100s of thousands of times with the
fix.

closes elastic#99649
@ChrisHegarty ChrisHegarty added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:QL (Deprecated) Meta label for query languages team labels Oct 9, 2023
@elasticsearchmachine elasticsearchmachine mentioned this pull request Oct 9, 2023
Merged
@elasticsearchmachine elasticsearchmachine merged commit c0f9a2c into elastic:8.11 Oct 9, 2023
@ChrisHegarty ChrisHegarty deleted the backport/8.11/pr-100547 branch October 9, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:QL (Deprecated) Meta label for query languages team >test Issues or PRs that are addressing/adding tests v8.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisHegarty @elasticsearchmachine