Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] BreakingBytesRefBuilderTests testGrow failing #99649

Closed
Tracked by #100147
iverase opened this issue Sep 19, 2023 · 3 comments · Fixed by #100547
Closed
Tracked by #100147

[CI] BreakingBytesRefBuilderTests testGrow failing #99649

iverase opened this issue Sep 19, 2023 · 3 comments · Fixed by #100547
Assignees
@ChrisHegarty
Labels
:Analytics/ES|QL AKA ESQL blocker Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI

Comments

@iverase
Copy link
Contributor

iverase commented Sep 19, 2023

Build scan:
https://gradle-enterprise.elastic.co/s/473uj5rvxi2zu/tests/:x-pack:plugin:esql:compute:test/org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests/testGrow

Reproduction line:

./gradlew ':x-pack:plugin:esql:compute:test' --tests "org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests.testGrow" -Dtests.seed=4083B2C88075935A -Dtests.locale=es-CL -Dtests.timezone=America/Miquelon -Druntime.java=20

Applicable branches:
main

Reproduces locally?:
Yes

Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests&tests.test=testGrow

Failure excerpt:

junit.framework.AssertionFailedError: Expected exception CircuitBreakingException but no exception was thrown

  at __randomizedtesting.SeedInfo.seed([4083B2C88075935A:4198227DC3383826]:0)
  at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2864)
  at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2850)
  at org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests.testAgainstOracle(BreakingBytesRefBuilderTests.java:126)
  at org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests.testGrow(BreakingBytesRefBuilderTests.java:76)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
  at java.lang.reflect.Method.invoke(Method.java:578)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:843)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:490)
  at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
  at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
  at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
  at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
  at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
  at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
  at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:390)
  at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
  at java.lang.Thread.run(Thread.java:1623)
@iverase iverase added :Analytics/ES|QL AKA ESQL >test-failure Triaged test failures from CI labels Sep 19, 2023
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Sep 19, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@iverase iverase mentioned this issue Sep 19, 2023
Merged
@luigidellaquila
Copy link
Contributor

Strictly related probably https://gradle-enterprise.elastic.co/s/o2w57fhmhpdfq/tests/task/:x-pack:plugin:esql:compute:test/details/org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests/testAddBytesRef?top-execution=1

elasticsearchmachine pushed a commit that referenced this issue Sep 19, 2023
@iverase
mute BreakingBytesRefBuilderTests#testGrow (#99651)
4fdfb33 
relates #99649
@luigidellaquila luigidellaquila mentioned this issue Sep 19, 2023
Merged
elasticsearchmachine pushed a commit that referenced this issue Sep 19, 2023
@luigidellaquila
Mute BreakingBytesRefBuilderTests#testAddBytesRef (#99653)
bf8429b 
Flaky tests

relates #99649
@nik9000 nik9000 self-assigned this Sep 19, 2023
@DaveCTurner DaveCTurner mentioned this issue Sep 20, 2023
Merged
@costin costin mentioned this issue Oct 9, 2023
Closed
23 tasks
@ChrisHegarty ChrisHegarty assigned ChrisHegarty and unassigned nik9000 Oct 9, 2023
@ChrisHegarty ChrisHegarty mentioned this issue Oct 9, 2023
Merged
elasticsearchmachine pushed a commit that referenced this issue Oct 9, 2023
@ChrisHegarty
Fix test (#100547)
6feb418 
This commit fixes the intermittent failure of
BreakingBytesRefBuilderTests. The issue is that the test uses the
BreakingBytesRefBuilder's internal BytesRef array length to determine
whether to expect a circuit breaker exception or not. Where it should
use the builders length (not the capacity, a.k.a the internal BytesRef
array length).

The test failed intermittently about one in 10-20 runs before the
change. The test passes successfully 100s of thousands of times with the
fix.

closes #99649
ChrisHegarty added a commit to ChrisHegarty/elasticsearch that referenced this issue Oct 9, 2023
@ChrisHegarty
Fix test (elastic#100547)
ac21ff8 
This commit fixes the intermittent failure of
BreakingBytesRefBuilderTests. The issue is that the test uses the
BreakingBytesRefBuilder's internal BytesRef array length to determine
whether to expect a circuit breaker exception or not. Where it should
use the builders length (not the capacity, a.k.a the internal BytesRef
array length).

The test failed intermittently about one in 10-20 runs before the
change. The test passes successfully 100s of thousands of times with the
fix.

closes elastic#99649
elasticsearchmachine pushed a commit that referenced this issue Oct 9, 2023
@ChrisHegarty
Fix test (#100547) (#100553)
c0f9a2c 
This commit fixes the intermittent failure of
BreakingBytesRefBuilderTests. The issue is that the test uses the
BreakingBytesRefBuilder's internal BytesRef array length to determine
whether to expect a circuit breaker exception or not. Where it should
use the builders length (not the capacity, a.k.a the internal BytesRef
array length).

The test failed intermittently about one in 10-20 runs before the
change. The test passes successfully 100s of thousands of times with the
fix.

closes #99649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisHegarty ChrisHegarty

Labels
:Analytics/ES|QL AKA ESQL blocker Team:QL (Deprecated) Meta label for query languages team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BreakingBytesRefBuilderTests testGrow failing ChrisHegarty/elasticsearch
5 participants
@nik9000 @luigidellaquila @iverase @elasticsearchmachine @ChrisHegarty