-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESQL: Silence failing test #100357
Merged
Merged
ESQL: Silence failing test #100357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not releasing blocks.
nik9000
added
>test-mute
Use for PR that only mute tests
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
auto-backport-and-merge
:Analytics/ES|QL
AKA ESQL
v8.11.0
v8.12.0
labels
Oct 5, 2023
elasticsearchmachine
added
the
Team:QL (Deprecated)
Meta label for query languages team
label
Oct 5, 2023
Pinging @elastic/es-ql (Team:QL) |
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
alex-spies
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💔 Backport failed
You can use sqren/backport to manually backport by running |
The backport for this one is waiting on #100353. |
23 tasks
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Oct 5, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 5, 2023
* ESQL: Remove aliasing inside Eval (#100238) Evals that introduce aliased can be simplified by extracting them into a project (and thus signaling there's no underlying processing). The following eval: eval x = a + 1, y = x, z = y + 1, y = z, w = y + 1 can be converted into: eval x = a + 1, z = a + 1 + 1, w = a + 1 + 1 | project x, z, z as y, w Fix #100174 Fix #100050 * Incorporate #100357 * Temporarily disable failing test Relates #100365 (cherry picked from commit 0ef4da2) * ESQL: Temporarily disable huge concat tests (#100352) We're working on these and we have a plan! (cherry picked from commit acca114) --------- Co-authored-by: Nik Everett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
Team:QL (Deprecated)
Meta label for query languages team
>test-mute
Use for PR that only mute tests
v8.11.0
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not releasing blocks.
Relates to #100356