Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Silence failing test #100357

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 5, 2023

It's not releasing blocks.

Relates to #100356

It's not releasing blocks.
@nik9000 nik9000 added >test-mute Use for PR that only mute tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge :Analytics/ES|QL AKA ESQL v8.11.0 v8.12.0 labels Oct 5, 2023
@nik9000 nik9000 requested a review from costin October 5, 2023 17:43
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticsearchmachine elasticsearchmachine merged commit 7ff9c9f into elastic:main Oct 5, 2023
@nik9000 nik9000 deleted the mute_rename branch October 5, 2023 18:03
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.11 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 100357

@nik9000
Copy link
Member Author

nik9000 commented Oct 5, 2023

The backport for this one is waiting on #100353.

@nik9000
Copy link
Member Author

nik9000 commented Oct 5, 2023

The backport for this one is waiting on #100353.

This is going to be included in #100353.

costin added a commit to costin/elasticsearch that referenced this pull request Oct 5, 2023
elasticsearchmachine pushed a commit that referenced this pull request Oct 5, 2023
* ESQL: Remove aliasing inside Eval (#100238)

Evals that introduce aliased can be simplified by extracting them into a
 project (and thus signaling there's no underlying processing).

The following eval:
  eval x = a + 1, y = x, z = y + 1, y = z, w = y + 1
can be converted into:
  eval x = a + 1, z = a + 1 + 1, w = a + 1 + 1 | project x, z, z as y, w

Fix #100174
Fix #100050

* Incorporate #100357

* Temporarily disable failing test

Relates #100365

(cherry picked from commit 0ef4da2)

* ESQL: Temporarily disable huge concat tests (#100352)

We're working on these and we have a plan!

(cherry picked from commit acca114)

---------

Co-authored-by: Nik Everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:QL (Deprecated) Meta label for query languages team >test-mute Use for PR that only mute tests v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants