Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Temporarily disable huge concat tests #100352

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Oct 5, 2023

We're working on these and we have a plan!

We're working on these and we have a plan!
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Oct 5, 2023
Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@elasticsearchmachine elasticsearchmachine merged commit acca114 into elastic:main Oct 5, 2023
@nik9000 nik9000 deleted the heap_attack_small_huge_concat_awaitsfix branch October 5, 2023 17:29
costin pushed a commit to costin/elasticsearch that referenced this pull request Oct 5, 2023
We're working on these and we have a plan!

(cherry picked from commit acca114)
@costin
Copy link
Member

costin commented Oct 5, 2023

FTR, the backport for 8.11 is picked up as part of #100353

elasticsearchmachine pushed a commit that referenced this pull request Oct 5, 2023
* ESQL: Remove aliasing inside Eval (#100238)

Evals that introduce aliased can be simplified by extracting them into a
 project (and thus signaling there's no underlying processing).

The following eval:
  eval x = a + 1, y = x, z = y + 1, y = z, w = y + 1
can be converted into:
  eval x = a + 1, z = a + 1 + 1, w = a + 1 + 1 | project x, z, z as y, w

Fix #100174
Fix #100050

* Incorporate #100357

* Temporarily disable failing test

Relates #100365

(cherry picked from commit 0ef4da2)

* ESQL: Temporarily disable huge concat tests (#100352)

We're working on these and we have a plan!

(cherry picked from commit acca114)

---------

Co-authored-by: Nik Everett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:QL (Deprecated) Meta label for query languages team v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants