-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] FullClusterRestartIT.testSearch fails on master #25311
Comments
We have another test failure in build 1172:
It is not reproducible locally so I conclude it is timing-related and the API endpoint does not always return data for the index that is checked in the predicate. |
That upgrade status should always return data for the index in that test, regardles whether an upgrade did actually run. I'll add some more logging. |
These failures didn't yet have the extra logging I added. |
Failures occurred over the weekend:
I think the upgrade status api was reporting incorrect stats because a refresh may not have occurred yet. I'll make sure a refresh is ran after the upgrade. |
Another failure: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+bwc-tests/122 .
|
This is just weird. I pushed another commit that checks the upgrade api response to check whether the index really was upgraded. |
That failure didn't yet have the commit that verifies the upgrade response. I'm interested in seeing if that fails too. |
Another two failures:
The upgrade api returns:
Indicating to the upgrade has not been performed. So I ssh-ed into the build slave used for the last build and the upgrade seem to be invoked:
However the |
This one failed in the same way: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+bwc-tests/129 However the log file does contain the
This is weird, because the upgrade api returned:
Indicating no upgrade ran. (which then failed the test) The log file also contained many restore failures (which the previous failures didn't have) (not sure if it is related):
|
This test hasn't after: 9040f44 got pushed. This commit changes to test to wait for green state before running upgrade. I noticed that in one of these build failures that shard header reported that the upgrade command was send to 0 shards. (total was 1 and successful was 1). If this test doesn't fail over the weekend then I will close this issue. |
happened again: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.0+bwc-tests/42/console
|
And again in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+bwc-tests/45/console
The failing assertion checks whether versions of upgraded indices are present (i.e. not null). Attached are the cluster logs from the 5.3.3 on which the test has failed. |
I see two things in the cluster logs:
I think both observations can be the reason why this test fails. |
This one looks similar: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+bwc-tests/57 |
So these tests are against the |
I'll open a PR to remove the failing test in a bit. If we end up with some other mystery error in the bwc tests we should keep this issue in mind, but I don't think it is worth spending a ton of time hunting this issue given that the API should go anyway. |
Our documentation for the API is: ``` The _upgrade API is no longer useful and will be removed. Instead, see Reindex to upgrade. ``` Given that, I don't think we need to test the API anymore. Closes elastic#25311
Our documentation for the API is: ``` The _upgrade API is no longer useful and will be removed. Instead, see Reindex to upgrade. ``` Given that, I don't think we need to test the API anymore. Closes #25311
Our documentation for the API is: ``` The _upgrade API is no longer useful and will be removed. Instead, see Reindex to upgrade. ``` Given that, I don't think we need to test the API anymore. Closes #25311
Our documentation for the API is: ``` The _upgrade API is no longer useful and will be removed. Instead, see Reindex to upgrade. ``` Given that, I don't think we need to test the API anymore. Closes #25311
Link to CI: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+bwc-tests/81/console
Reproduce with:
Could not reproduce it.
Full error:
The text was updated successfully, but these errors were encountered: