Rest only High Level APIs completeness #47678

hub-cap · 2019-10-07T17:16:55Z

There are a number of API that are exposed via REST but not via the Transport Client. They don't necessarily have to be implemented if the goal is feature parity with the Transport Client, yet we should probably have a look at why they were not added to the Transport Client and whether it makes sense to add their support to the high-level REST Client or not. I don't think it makes sense to add support for cat API and ingest processor grok, hence I took them out already.

cluster remote info (@J-Bean)
get source (@timoninmaxim)
delete alias (@hub-cap)
~~- [ ] get upgrade (@timoninmaxim)~~
get grok patterns (GET /_ingest/processor/grok) (@jesinity)

taken from #27205

elasticmachine · 2019-10-07T17:16:57Z

Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client)

qianyuxiang01 · 2019-10-08T08:20:55Z

Do you plan to complete those legacy RHLC api? @hub-cap

har-vy · 2019-10-09T04:59:49Z

Hi @hub-cap, I am a beginner, can I work on this?

hub-cap · 2019-10-10T14:39:28Z

@qianyuxiang01 I do not plan to personally complete these. I welcome community submissions.

@har-vy YES U CAN! :D Just pick one, maybe delete alias (the payload on the response is likely smaller so its easier to deal with). Feel free to post up a WIP and ask questions.

deivids682 · 2019-10-13T10:44:42Z

Hi, @har-vy do you take a look? I can manage to do this one.

har-vy · 2019-10-13T11:24:56Z

@Deivids sure, I would probably have to pass this on.

The delete alias call is a rest only API call, but should still be added to the rest client. This commit adds it as well as relevant tests. Ref elastic#47678

mohamadLy · 2019-11-11T18:17:08Z

Hi, anyone on this right now. I was thinking picking it up if possible

hub-cap · 2019-11-11T19:21:03Z

I have done the delete alias. You can feel free to choose one of the API's and tell me so I can put your name next to it.

mohamadLy · 2019-11-11T20:08:20Z

Hub-cap thanks for the quick reply. I think I'll go with the source API

The delete alias call is a rest only API call, but should still be added to the rest client. This commit adds it as well as relevant tests. Ref #47678

mohamadLy · 2019-11-12T14:17:33Z

Hi hub-cap,

I am having issue build the source code. I am trying to build it on ubuntu 18.04. Doesn't seem like java12 exist for ubuntu 18.04. I tried to build with java13 but that did not work either. Do you know any orkaround for this?

I apologize if this is not the right place to post the question.

andrewjohnson2 · 2019-11-12T16:30:29Z

Hi, is anyone doing get upgrade? If not I can take it!

The delete alias call is a rest only API call, but should still be added to the rest client. This commit adds it as well as relevant tests. Ref #47678

hub-cap · 2019-11-12T17:36:32Z

@mohamadLy see https://github.com/elastic/elasticsearch/blob/master/CONTRIBUTING.md#contributing-to-the-elasticsearch-codebase

@andrewjohnson2 I can mark you down if you like.

andrewjohnson2 · 2019-11-15T16:33:55Z

Thanks! I am new to the project and trying to understand some things. To clarify, there is a REST API that exposes get upgrade and I need to implement get upgrade in the high level REST client? Where in the codebase is it currently implemented? Thanks

mohamadLy · 2019-11-15T17:06:38Z

@andrewjohnson2 I am pretty new to this project also, trying to implement get source. Been doing some investigation on how to go about it. This is the path to the source code where you need to make your changes
https://github.com/elastic/elasticsearch/tree/master/client/rest-high-level/src/main/java/org/elasticsearch/client
I let the others reply to your other question since they are more knowledgeable about the project then I do.
Do you know it is possible to import our custom Rest High Level Client Jar on the different project? What I mean is that I build the source and would like to test my implementation. It would be great if can import that Jar to my little test program to test.

hrealinho · 2019-11-15T20:56:25Z

hey guys. first time contributor here, what API would who like me to try and tackle? @hub-cap
Cheers!

andrewjohnson2 · 2019-11-18T15:43:06Z

I did some more research and found this:
https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestUpgradeStatusAction.java
file which appears to be the existing get upgrade implementation. Is this correct? If so I tried reading the API docs and found that the /_upgrade API has been deprecated? https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-upgrade.html
Any assistance is really appreciated. Thanks!

hub-cap · 2019-11-18T18:00:22Z

So, these are tricky APIs since they are REST only. This means they may not have a specific transport action associated w/ them. The best way to find it is what @andrewjohnson2 has pointed out, which is to find the URI of the action in question, _upgrade, in this case, which maps to this.

You are right @andrewjohnson2 that this will be removed in the future, but it still exists today, so its still a valid use case for the client.

hub-cap · 2019-11-18T18:00:39Z

@hrealinho you can choose one of the APIs that is not taken above

andrewjohnson2 · 2019-11-18T18:20:12Z

@hub-cap thanks so much! For get upgrade specifically, will the implementation be similar in nature to the delete alias implementation? Such as editing similar files and such? If not do you have any references that could layout what needs to happen in general to implement these APIs? Thanks!

hub-cap · 2019-11-18T20:12:23Z

yes @andrewjohnson2 you should be able to use that as a guide.

Relates to #47678

Relates to elastic#47678

Backport to 7.x branch of #50885. Relates to #47678 Co-authored-by: Maxim <[email protected]>

timoninmaxim · 2020-01-24T12:28:37Z

@martijnvg thanks a lot for the help with the tasks. It were my first PRs ever to opensource projects!

martijnvg · 2020-01-24T14:23:27Z

@timoninmaxim You're welcome and thank you for picking up these tasks!

Priya-Raut · 2020-05-23T15:08:16Z

Is get grok patterns API still available to start working on it?

jesinity · 2020-05-23T15:40:01Z

It is available if you want ti pick it

Priya-Raut · 2020-05-23T16:37:43Z

Thanks! I will start working on it then.
@hub-cap could you please put my name next to 'get grok patterns'?

Priya-Raut · 2020-05-25T05:01:10Z

Hi,
I am trying to contribute to elasticsearch for the first time. I am not able to run the code yet.
After following instructions from CONTRIBUTING.md,

JAVA_HOME is set to JDK 14
The project is imported in Intellij 2020.1
Docker is not set up yet
Ran the command ./gradlew :run

However, it is running forever.
Can someone please point out if I am doing something wrong?

Here are additional details about my environment:
Elasticsearch Build Hamster says Hello!
Gradle Version : 6.4.1
OS Info : Mac OS X 10.14.6 (x86_64)
JDK Version : 14 (Oracle JDK)
JAVA_HOME : /Library/Java/JavaVirtualMachines/jdk-14.jdk/Contents/Home
Random Testing Seed : A339F561FEBB215C
In FIPS 140 mode : false

tvernum · 2020-05-25T05:12:42Z

However, it is running forever.

What does "forever" mean exactly?
Elasticsearch is big, and it takes a fair amount of time to compile, but it should not take hours on modern hardware.

Is the build running, but slowly? Or has it stalled completely (and if so, where)?

Priya-Raut · 2020-05-25T05:32:38Z

What does "forever" mean exactly?

Right! So, it has been running for about 2 hours now.

Is the build running, but slowly? Or has it stalled completely (and if so, where)?

It has stalled at this line
[2020-05-25T09:08:20,481][INFO ][o.e.x.i.a.TransportPutLifecycleAction] [runTask-0] adding index lifecycle policy [ml-size-based-ilm-policy]

I put the logs at a google doc here:
https://docs.google.com/document/d/1-GSai74eiXt2yQIF1wB1x0bmG-ejEls-eJOP2LEyKfw/edit?usp=sharing

tvernum · 2020-05-25T05:51:38Z

Aha! It's not actually stalled, it's running and waiting for you to do stuff.

I'll open an issue to clarify the CONTRIBUTING instructions - it's definitely not clear from that doc or from the build output that it's at the point where you can actually connect.

At this point you can just connect via curl (in a different terminal session) with

curl -u elastic:password localhost:9200

Priya-Raut · 2020-05-25T05:57:06Z

@tvernum Thanks a lot! It means I was waiting for nothing ><

I'll open an issue to clarify the CONTRIBUTING instructions - it's definitely not clear from that doc or from the build output that it's at the point where you can actually connect.

Excellent idea!

I got the response! yay!
{
"name" : "runTask-0",
"cluster_name" : "runTask",
"cluster_uuid" : "8FnkV_YLSxmkhxB0yyVYBw",
"version" : {
"number" : "8.0.0-SNAPSHOT",
"build_flavor" : "default",
"build_type" : "tar",
"build_hash" : "2a8b5787466c1e2e478c266db76bd2fba580c1ce",
"build_date" : "2020-05-25T05:37:19.699441Z",
"build_snapshot" : true,
"lucene_version" : "8.6.0",
"minimum_wire_compatibility_version" : "7.9.0",
"minimum_index_compatibility_version" : "7.0.0"
},
"tagline" : "You Know, for Search"
}

Priya-Raut · 2020-05-25T10:40:49Z

I have started working on the get grok patterns (GET /_ingest/processor/grok) API call to include it in the client.
I have a few queries. Can anyone please help me out? ^^'

(Just to confirm) is this the API we need include in the client?
https://www.elastic.co/guide/en/elasticsearch/reference/current/grok-processor.html#grok-processor-rest-get
I am planning to put the code in RestHighLevelClient.java
Is it ok? If not, where should I move it?
Where should the client-side documentation be placed under this location?
https://www.elastic.co/guide/en/elasticsearch/client/java-rest/7.7/java-rest-high.html
How about under the 'Miscellaneous API' category?

sethmlarson · 2020-07-01T23:55:02Z

Back in #27205 there were APIs that were left off the list (because they expose ShardRouting and ClusterState) and that information didn't make the leap to this issue. Is there any plan on implementing these APIs? cc @e-mars

Chr0nicl3 · 2020-09-26T12:49:29Z

@Priya-Raut are you still working on the solution?
If not, I'd like to work on this issue.
@hub-cap

* Deprecates _upgrade API Ref elastic#47678 * Move deprecation flags to path section. Add deprecation warning tests for _upgrade API. Ref elastic#47678

timothy-choi · 2023-03-24T03:01:53Z

Hi @hub-cap . Is this issue still open? I would like to work on this issue.

dakrone · 2023-03-24T14:58:17Z

The Java Rest High Level Client has been deprecated (and removed) in later versions of Elasticsearch, in favor of the official Elasticsearch Java Client — https://github.com/elastic/elasticsearch-java

I'm going to close this issue since it is no longer needed.

hub-cap added >enhancement good first issue low hanging fruit :Core/Features/Java High Level REST Client labels Oct 7, 2019

hub-cap mentioned this issue Oct 7, 2019

Java high-level REST client completeness #27205

Closed

80 tasks

hub-cap added a commit to hub-cap/elasticsearch that referenced this issue Nov 1, 2019

Add delete alias to the HLRC

49062f4

The delete alias call is a rest only API call, but should still be added to the rest client. This commit adds it as well as relevant tests. Ref elastic#47678

hub-cap mentioned this issue Nov 1, 2019

Add delete alias to the HLRC #48819

Merged

hub-cap added a commit that referenced this issue Nov 11, 2019

Add delete alias to the HLRC (#48819)

7115d3e

The delete alias call is a rest only API call, but should still be added to the rest client. This commit adds it as well as relevant tests. Ref #47678

hub-cap added a commit that referenced this issue Nov 12, 2019

Add delete alias to the HLRC (#48819)

bc23bc5

The delete alias call is a rest only API call, but should still be added to the rest client. This commit adds it as well as relevant tests. Ref #47678

martijnvg pushed a commit that referenced this issue Jan 23, 2020

Add Get Source API to the HLRC (#50885)

c019230

Relates to #47678

martijnvg pushed a commit to martijnvg/elasticsearch that referenced this issue Jan 23, 2020

Add Get Source API to the HLRC (elastic#50885)

814d5fb

Relates to elastic#47678

martijnvg mentioned this issue Jan 23, 2020

Backport: Add Get Source API to the HLRC #51342

Merged

martijnvg added a commit that referenced this issue Jan 23, 2020

Add Get Source API to the HLRC (#51342)

0a8d8d7

Backport to 7.x branch of #50885. Relates to #47678 Co-authored-by: Maxim <[email protected]>

This was referenced Feb 3, 2020

[meta] 7.6 release elastic/elasticsearch-net#4340

Closed

[meta] 7.6 release elastic/elasticsearch-net#4341

Closed

codebrain mentioned this issue Apr 1, 2020

7.7.0 meta ticket (Part 2) elastic/elasticsearch-net#4533

Closed

rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020

tvernum mentioned this issue May 25, 2020

CONTRIBUTING.md doesn't explain when :run is done #57097

Closed

Priya-Raut mentioned this issue Jun 6, 2020

Add get grok patterns api in HLRC [#47678] #57780

Closed

1 task

danhermann mentioned this issue Nov 5, 2020

[7.x] Deprecate _upgrade API #64677

Merged

stevejgordon mentioned this issue Dec 17, 2020

7.11.0 Meta Ticket elastic/elasticsearch-net#5198

Closed

dakrone closed this as completed Mar 24, 2023

Rest only High Level APIs completeness #47678

Rest only High Level APIs completeness #47678

Comments

hub-cap commented Oct 7, 2019 • edited by martijnvg Loading

elasticmachine commented Oct 7, 2019

qianyuxiang01 commented Oct 8, 2019

har-vy commented Oct 9, 2019

hub-cap commented Oct 10, 2019

deivids682 commented Oct 13, 2019

har-vy commented Oct 13, 2019

mohamadLy commented Nov 11, 2019

hub-cap commented Nov 11, 2019

mohamadLy commented Nov 11, 2019

mohamadLy commented Nov 12, 2019

andrewjohnson2 commented Nov 12, 2019

hub-cap commented Nov 12, 2019

andrewjohnson2 commented Nov 15, 2019

mohamadLy commented Nov 15, 2019 • edited Loading

hrealinho commented Nov 15, 2019

andrewjohnson2 commented Nov 18, 2019

hub-cap commented Nov 18, 2019

hub-cap commented Nov 18, 2019

andrewjohnson2 commented Nov 18, 2019 • edited Loading

hub-cap commented Nov 18, 2019

timoninmaxim commented Jan 24, 2020

martijnvg commented Jan 24, 2020

Priya-Raut commented May 23, 2020

jesinity commented May 23, 2020

Priya-Raut commented May 23, 2020 • edited Loading

Priya-Raut commented May 25, 2020 • edited Loading

tvernum commented May 25, 2020

Priya-Raut commented May 25, 2020 • edited Loading

tvernum commented May 25, 2020

Priya-Raut commented May 25, 2020 • edited Loading

Priya-Raut commented May 25, 2020 • edited Loading

sethmlarson commented Jul 1, 2020 • edited Loading

Chr0nicl3 commented Sep 26, 2020 • edited Loading

timothy-choi commented Mar 24, 2023

dakrone commented Mar 24, 2023

hub-cap commented Oct 7, 2019 •

edited by martijnvg

Loading

mohamadLy commented Nov 15, 2019 •

edited

Loading

andrewjohnson2 commented Nov 18, 2019 •

edited

Loading

Priya-Raut commented May 23, 2020 •

edited

Loading

Priya-Raut commented May 25, 2020 •

edited

Loading

Priya-Raut commented May 25, 2020 •

edited

Loading

Priya-Raut commented May 25, 2020 •

edited

Loading

Priya-Raut commented May 25, 2020 •

edited

Loading

sethmlarson commented Jul 1, 2020 •

edited

Loading

Chr0nicl3 commented Sep 26, 2020 •

edited

Loading