Autocast Keyword to Date in Date Nanos comparisons #118476
Assignees
Labels
:Analytics/ES|QL
AKA ESQL
>enhancement
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
Comments
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
not-napoleon
added a commit
to not-napoleon/elasticsearch
that referenced
this issue
Dec 17, 2024
resolves elastic#118476 This adds an implicit cast from string to date nanos, much the same as we do for millisecond dates. In the course of working on this, I found and fixed a couple of tests that were creating pre-epoch date nanos, which are not supported in elasticsearch. I also refactored the conversion code to use the standard DateUtils functions where appropriate, which caught some of the above errors in test data.
elasticsearchmachine
pushed a commit
that referenced
this issue
Dec 17, 2024
resolves #118476 This adds an implicit cast from string to date nanos, much the same as we do for millisecond dates. In the course of working on this, I found and fixed a couple of tests that were creating pre-epoch date nanos, which are not supported in elasticsearch. I also refactored the conversion code to use the standard DateUtils functions where appropriate, which caught some of the above errors in test data.
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this issue
Dec 18, 2024
resolves elastic#118476 This adds an implicit cast from string to date nanos, much the same as we do for millisecond dates. In the course of working on this, I found and fixed a couple of tests that were creating pre-epoch date nanos, which are not supported in elasticsearch. I also refactored the conversion code to use the standard DateUtils functions where appropriate, which caught some of the above errors in test data.
navarone-feekery
pushed a commit
to navarone-feekery/elasticsearch
that referenced
this issue
Dec 26, 2024
resolves elastic#118476 This adds an implicit cast from string to date nanos, much the same as we do for millisecond dates. In the course of working on this, I found and fixed a couple of tests that were creating pre-epoch date nanos, which are not supported in elasticsearch. I also refactored the conversion code to use the standard DateUtils functions where appropriate, which caught some of the above errors in test data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#116281 added support for comparing nanosecond dates and millisecond dates, but it didn't extend the keyword to date auto-promotion logic to that case. We would like that to work, so that expressions like
nanos > "2023-01-01"are valid ES|QL.The text was updated successfully, but these errors were encountered: