Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for mixed comparisons between millis and nanos #116281

Closed
Tracked by #109352
not-napoleon opened this issue Nov 5, 2024 · 1 comment · Fixed by #118027
Closed
Tracked by #109352

Allow for mixed comparisons between millis and nanos #116281

not-napoleon opened this issue Nov 5, 2024 · 1 comment · Fixed by #118027
Assignees
@not-napoleon
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@not-napoleon
Copy link
Member

not-napoleon commented Nov 5, 2024 •
edited
Loading

If we want to enable a seamless transition for saved queries, we need to support mixed-type comparisons. Saved queries are likely to have clauses like | WHERE ts > "2023-10-23T13:00:00Z", and the auto-casting will promote the string to a millisecond date and the timestamp to a nanosecond date. For that to then work, we need to support a comparison between millisecond dates and nanosecond dates.
@not-napoleon not-napoleon mentioned this issue Nov 5, 2024
Open
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Nov 5, 2024
@not-napoleon not-napoleon added >enhancement :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label labels Nov 5, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@not-napoleon not-napoleon self-assigned this Dec 4, 2024
@not-napoleon not-napoleon mentioned this issue Dec 4, 2024
Merged
not-napoleon added a commit that referenced this issue Dec 6, 2024
@not-napoleon
Esql compare nanos and millis (#118027)
7cd17d2 
Resolves #116281

Introduces support for comparing millisecond dates with nanosecond dates, without the need for casting. Millisecond dates outside of the nanosecond date range are handled correctly.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this issue Dec 6, 2024
@not-napoleon
Esql compare nanos and millis (elastic#118027)
fdb36aa 
Resolves elastic#116281

Introduces support for comparing millisecond dates with nanosecond dates, without the need for casting. Millisecond dates outside of the nanosecond date range are handled correctly.
elasticsearchmachine pushed a commit that referenced this issue Dec 6, 2024
@not-napoleon
Esql compare nanos and millis (#118027) (#118159)
7f1d7c4 
Resolves #116281

Introduces support for comparing millisecond dates with nanosecond dates, without the need for casting. Millisecond dates outside of the nanosecond date range are handled correctly.
@not-napoleon not-napoleon mentioned this issue Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@not-napoleon not-napoleon

Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Esql compare nanos and millis not-napoleon/elasticsearch
2 participants
@not-napoleon @elasticsearchmachine