Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adding text embedding byte representation #2411

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jonathan-buttner
Copy link
Contributor

This PR adds the text embedding byte representation. This is to resolve the problems with the original PR: #2398 which caused the client generates to fail because it was unable to deduce the response format.

These changes coincide with the server changes here: elastic/elasticsearch#105290

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete_model Missing test Missing test
inference.get_model 🔴 1/1 0/1
inference.inference Missing test Missing test
inference.put_model Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-buttner jonathan-buttner merged commit 4cb8434 into main Feb 8, 2024
12 of 13 checks passed
@jonathan-buttner jonathan-buttner deleted the ml-support-text-embedding-bytes branch February 8, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants