Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding signed byte support from cohere integration #2398

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

jonathan-buttner
Copy link
Contributor

This PR is to reflect the proposed changes included in this PR: elastic/elasticsearch#104559 which adds support for the Cohere 3rd party service. By adding Cohere we also would like to support signed bytes as a response format for dense vector.

I'll leave this in draft until the elasticsearch PR is merged.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete_model Missing test Missing test
inference.get_model 🔴 1/1 0/1
inference.inference Missing test Missing test
inference.put_model Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@jonathan-buttner jonathan-buttner marked this pull request as ready for review January 25, 2024 14:10
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do you know why the validation failed for inference.get_model

@jonathan-buttner
Copy link
Contributor Author

Do you know why the validation failed for inference.get_model

Hmm, no I'm not sure. That's weird 🤔

@jonathan-buttner jonathan-buttner merged commit 203108f into main Jan 30, 2024
13 of 14 checks passed
@jonathan-buttner jonathan-buttner deleted the ml-support-in8 branch January 30, 2024 15:38
l-trotta added a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants